Typestate #393
Closed
Typestate #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments in a pattern
Started by rewriting collect_locals to use walk instead of fold
This required quite a bit of tiresome plumbing about of spans. On the bright side, now other errors can be converted to span_err too. Includes test cases.
Added visit_fn_pre and visit_fn_post fields that get applied to both regular functions and methods.
and various other tidying in typestate
and kill dead code.
|
Awesome, thanks. Integrated. |
calebzulawski
added a commit
to calebzulawski/rust
that referenced
this pull request
Feb 17, 2024
Assume masks are correct
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Add support to Ubuntu 18.04 (rust-lang#393) Issue: Our python scripts use python 3.8+ while ubuntu 18.04 defaults to python 3.6. Changes: * Change our scripts to use constructs available in older python versions. * Modify workflows file to add ubuntu-18.04. * Make ubuntu scripts generic. * Change copyright check script to ignore directories and symbolic links to directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typestate now entirely uses walk instead of fold; other cleanup as well. With a bonus error message improvement to trans.