Skip to content

comment rewording and argument unifying #39402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2017
Merged

comment rewording and argument unifying #39402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986dd07
doc comment reword
king6cong Jan 30, 2017
701c32e
unify time_passes argument passing
king6cong Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/librustc_driver/driver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,15 +741,15 @@ pub fn phase_2_configure_and_expand<F>(sess: &Session,
"checking for inline asm in case the target doesn't support it",
|| no_asm::check_crate(sess, &krate));

time(sess.time_passes(),
time(time_passes,
"early lint checks",
|| lint::check_ast_crate(sess, &krate));

time(sess.time_passes(),
time(time_passes,
"AST validation",
|| ast_validation::check_crate(sess, &krate));

time(sess.time_passes(), "name resolution", || -> CompileResult {
time(time_passes, "name resolution", || -> CompileResult {
// Since import resolution will eventually happen in expansion,
// don't perform `after_expand` until after import resolution.
after_expand(&krate)?;
Expand All @@ -770,7 +770,7 @@ pub fn phase_2_configure_and_expand<F>(sess: &Session,
})?;

// Lower ast -> hir.
let hir_forest = time(sess.time_passes(), "lowering ast -> hir", || {
let hir_forest = time(time_passes, "lowering ast -> hir", || {
let hir_crate = lower_crate(sess, &krate, &mut resolver);

if sess.opts.debugging_opts.hir_stats {
Expand All @@ -780,7 +780,7 @@ pub fn phase_2_configure_and_expand<F>(sess: &Session,
hir_map::Forest::new(hir_crate, &sess.dep_graph)
});

// Discard hygiene data, which isn't required past lowering to HIR.
// Discard hygiene data, which isn't required after lowering to HIR.
if !keep_hygiene_data(sess) {
syntax::ext::hygiene::reset_hygiene_data();
}
Expand Down