-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rework TraitSelect
to avoid a vec and just use two def-ids
#39912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework TraitSelect
to avoid a vec and just use two def-ids
#39912
Conversation
cc @nnethercote -- forgot about this for a while |
Anyway I hope to remove this |
@bors r+ |
📌 Commit 4749175 has been approved by |
// Note that it's always sound to conflate dep-nodes, it just | ||
// leads to more recompilation. | ||
let def_ids: Vec<_> = | ||
// Extact the trait-def and first def-id from inputs. See the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Extract"
Cool. Any measurements? |
…eddyb rework `TraitSelect` to avoid a vec and just use two def-ids r? @eddyb
☀️ Test successful - status-appveyor, status-travis |
r? @eddyb