-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Variable Bindings possible nitpick #39923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Complete drive by nitpick I'm afraid
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ rollup Thank you! Nitpicks are good 😄 |
📌 Commit 5fa50d9 has been approved by |
Variable Bindings possible nitpick Complete drive by nitpick I'm afraid
⌛ Testing commit 5fa50d9 with merge 63ddc10... |
💔 Test failed - status-travis |
@bors: retry this seems spurious |
Variable Bindings possible nitpick Complete drive by nitpick I'm afraid
☀️ Test successful - status-appveyor, status-travis |
Complete drive by nitpick I'm afraid