Skip to content

Rollup of 2 pull requests #41424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 20, 2017
Merged

Rollup of 2 pull requests #41424

merged 10 commits into from
Apr 20, 2017

Conversation

frewsxcv
Copy link
Member

mgattozzi and others added 10 commits March 24, 2017 23:29
In rust-lang#29370 it's noted that for "the Note shouldn't be one, and should come before
the examples." This commit changes the positioning of the section and removes
wording that said take note in order for it to flow better with the surrounding
text and it's new position.
Update `Child` docs to not have a note section

In rust-lang#29370 it's noted that for "the Note shouldn't be one, and should come before
the examples." This commit changes the positioning of the section and removes
wording that said take note in order for it to flow better with the surrounding
text and it's new position.
API docs: Convert

Clean up of the convert module documentation following points in rust-lang#29349
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

@bors p=10 r+

@bors
Copy link
Collaborator

bors commented Apr 20, 2017

📌 Commit 9d91822 has been approved by frewsxcv

@bors
Copy link
Collaborator

bors commented Apr 20, 2017

⌛ Testing commit 9d91822 with merge ddc5d7b...

bors added a commit that referenced this pull request Apr 20, 2017
Rollup of 2 pull requests

- Successful merges: #40812, #40987
- Failed merges:
@bors
Copy link
Collaborator

bors commented Apr 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing ddc5d7b to master...

@bors bors merged commit 9d91822 into rust-lang:master Apr 20, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants