-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add spacing between trait functions #43130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some changes occurred in HTML/CSS. |
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
f9318a6
to
a8bd861
Compare
Something worth noting, is that the spacers you're adding are mechanically different from the one that's already there between the required methods and the provided ones. The existing spacer just printed an extra |
...also, travis ICE'd when running rustdoc, saying that it underflowed a subtraction.
|
a8bd861
to
052df6a
Compare
052df6a
to
12dccbd
Compare
From a conversation on IRC, imperio mentioned that the different mechanism is there to allow for different spacing within a section than between them. It's kinda subtle, but now that I know what it's for, I see it. r=me pending travis. |
@bors r+ Thanks! |
📌 Commit 12dccbd has been approved by |
⌛ Testing commit 12dccbd with merge 65cfc8f8c5e9d4e28e1392560005fa7a24cdf25d... |
@bors: r=QuietMisdreavus |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 12dccbd has been approved by |
…reavus Add spacing between trait functions Fixes #42988. <img width="1440" alt="screen shot 2017-07-09 at 17 02 16" src="https://user-images.githubusercontent.com/3050060/27995068-672a3208-64c8-11e7-9bc7-c7288f2cd27b.png">
☀️ Test successful - status-appveyor, status-travis |
Fixes #42988.