Skip to content

librustc_driver: Remove -Z option from usage on stable compiler #43556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2017

Conversation

tesaguri
Copy link
Contributor

The -Z flag has been disabled since Rust 1.19 stable, but it still shows in rustc --help.

This PR addresses the inconsistency by removing the message on the stable channel.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -795,19 +795,23 @@ fn usage(verbose: bool, include_unstable_options: bool) {
(option.apply)(&mut options);
}
let message = format!("Usage: rustc [OPTIONS] INPUT");
let extra_help = if verbose {
let debug_help = if nightly_options::is_nightly_build() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: nightly_help is a better name.

@arielb1
Copy link
Contributor

arielb1 commented Jul 30, 2017

r=me with the variable as nightly_help

@tesaguri tesaguri force-pushed the remove-z-opt-usage branch from ad43d8b to 39ef545 Compare July 30, 2017 09:55
@tesaguri
Copy link
Contributor Author

I changed the variable's name.

r? @arielb1

@arielb1
Copy link
Contributor

arielb1 commented Jul 30, 2017

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 30, 2017

📌 Commit 39ef545 has been approved by arielb1

@bors
Copy link
Collaborator

bors commented Jul 30, 2017

⌛ Testing commit 39ef545 with merge aac223f...

bors added a commit that referenced this pull request Jul 30, 2017
librustc_driver: Remove -Z option from usage on stable compiler

The `-Z` flag has been disabled since Rust 1.19 stable, but it still shows in `rustc --help`.

This PR addresses the inconsistency by removing the message on the stable channel.
@bors
Copy link
Collaborator

bors commented Jul 30, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing aac223f to master...

@bors bors merged commit 39ef545 into rust-lang:master Jul 30, 2017
@tesaguri tesaguri deleted the remove-z-opt-usage branch July 31, 2017 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants