-
Notifications
You must be signed in to change notification settings - Fork 13.3k
librustc_driver: Remove -Z option from usage on stable compiler #43556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/librustc_driver/lib.rs
Outdated
@@ -795,19 +795,23 @@ fn usage(verbose: bool, include_unstable_options: bool) { | |||
(option.apply)(&mut options); | |||
} | |||
let message = format!("Usage: rustc [OPTIONS] INPUT"); | |||
let extra_help = if verbose { | |||
let debug_help = if nightly_options::is_nightly_build() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: nightly_help
is a better name.
r=me with the variable as |
ad43d8b
to
39ef545
Compare
I changed the variable's name. r? @arielb1 |
@bors r+ rollup |
📌 Commit 39ef545 has been approved by |
librustc_driver: Remove -Z option from usage on stable compiler The `-Z` flag has been disabled since Rust 1.19 stable, but it still shows in `rustc --help`. This PR addresses the inconsistency by removing the message on the stable channel.
☀️ Test successful - status-appveyor, status-travis |
The
-Z
flag has been disabled since Rust 1.19 stable, but it still shows inrustc --help
.This PR addresses the inconsistency by removing the message on the stable channel.