[beta] syntax: avoid loading the same source-file multiple times #43840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had a cache for file contents, but we read the source-file before testing the cache, causing obvious slowness, so this just avoids loading the source-file when the cache already has the contents.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
This is a backport of part of #43584, right? If so, r=me. |
|
yeah |
|
@bors r+ |
|
📌 Commit a3387eb has been approved by |
|
Awesome thanks @arielb1! |
alexcrichton
changed the title
|
@alexcrichton (the second commit fixes a "different" O(n^2) discovered by the test case) |
|
Oh yeah that sounds fine to me to not backport |
|
@bors: p=2 (beta backport) |
bors
added a commit
that referenced
this pull request
Aug 13, 2017
[beta] syntax: avoid loading the same source-file multiple times We already had a cache for file contents, but we read the source-file before testing the cache, causing obvious slowness, so this just avoids loading the source-file when the cache already has the contents.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had a cache for file contents, but we read the source-file
before testing the cache, causing obvious slowness, so this just avoids
loading the source-file when the cache already has the contents.