Fnty args rustdoc #44892
Fnty args rustdoc #44892
Conversation
aidanhs
added
the
S-waiting-on-review
src/librustc/hir/mod.rs
Outdated
There was a problem hiding this comment.
When we discussed it, you were supposed to put it in BareFnTy. That should simplify things.
GuillaumeGomez
force-pushed
the
fnty-args-rustdoc
branch
from
a644487 to
075c90a
Compare
|
Updated. |
src/librustc/hir/mod.rs
Outdated
src/librustdoc/clean/mod.rs
Outdated
There was a problem hiding this comment.
Changing this impl means you've done something wrong...
src/librustdoc/clean/mod.rs
Outdated
There was a problem hiding this comment.
BareFnTy has its own Clean impl, you should be changing that, not this - this is why I didn't want you to change the enum variant, but the struct.
GuillaumeGomez
force-pushed
the
fnty-args-rustdoc
branch
from
075c90a to
81c2eff
Compare
|
Updated. |
src/librustdoc/clean/mod.rs
Outdated
src/librustdoc/clean/mod.rs
Outdated
There was a problem hiding this comment.
The existing impls are already powerful enough for this (unless I wasn't careful), all you need is to replace &[][..] with &self.arg_names.
There was a problem hiding this comment.
Not exactly:
no method named `clean` found for type `(&rustc::hir::FnDecl, &syntax::ptr::P<[syntax::codemap::Spanned<syntax::ast::Symbol>]>)` in the current scope
--> src/librustdoc/clean/mod.rs:2507:50
|
2507 | decl: (&*self.decl, &self.arg_names).clean(cx),
| ^^^^^
|
= note: the method `clean` exists but the following trait bounds were not satisfied:
`(&[syntax::ptr::P<rustc::hir::Ty>], &syntax::ptr::P<[syntax::codemap::Spanned<syntax::ast::Symbol>]>) : clean::Clean<clean::Arguments>`
= help: items from traits can only be used if the trait is implemented and in scope
= note: the following trait defines an item `clean`, perhaps you need to implement it:
candidate #1: `clean::Clean`
There was a problem hiding this comment.
Sounds like you need &self.arg_names[..] instead?
There was a problem hiding this comment.
Like, look for ForeignItemFn, it starts off with the same information but it doesn't implement the cleaning itself.
GuillaumeGomez
force-pushed
the
fnty-args-rustdoc
branch
2 times, most recently
from
1b80222 to
56c3dda
Compare
GuillaumeGomez
force-pushed
the
fnty-args-rustdoc
branch
from
56c3dda to
fe24e81
Compare
|
Updated. |
|
@bors r+ |
|
📌 Commit fe24e81 has been approved by |
Fnty args rustdoc Fixes #44570. cc @QuietMisdreavus cc @rust-lang/dev-tools Considering the impact on the `hir` libs, I'll put @eddyb as reviewer. r? @eddyb
|
☀️ Test successful - status-appveyor, status-travis |
4 participants
Fixes #44570.
cc @QuietMisdreavus
cc @rust-lang/dev-tools
Considering the impact on the
hirlibs, I'll put @eddyb as reviewer.r? @eddyb