compiletest: account for ui reference files when deciding to skip
#46533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
commented
Dec 6, 2017
| .reqopt("", "cc", "path to a C compiler", "PATH") | ||
| .reqopt("", "cxx", "path to a C++ compiler", "PATH") | ||
| .reqopt("", "cflags", "flags for the C compiler", "FLAGS") | ||
| .optopt("", "ar", "path to an archiver", "PATH") | ||
| .optopt("", "linker", "path to a linker", "PATH") | ||
| .reqopt("", "llvm-components", "list of LLVM components built in", "LIST") | ||
| .reqopt( | ||
| "", |
There was a problem hiding this comment.
Egads. I guess I ran rustfmt by accident.
nikomatsakis
force-pushed
the
ui-stamp-files
branch
from
72a0ec0 to
c7ec4a5
Compare
|
|
nikomatsakis
force-pushed
the
ui-stamp-files
branch
from
c7ec4a5 to
8681290
Compare
kennytm
added
the
S-waiting-on-author
|
@bors: r+ |
|
📌 Commit 7b456c0 has been approved by |
kennytm
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 7, 2017
compiletest: account for `ui` reference files when deciding to skip The stamp files for compiletest were ignoring `.stderr` and `.stdout` files. This was driving me crazy. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stamp files for compiletest were ignoring
.stderrand.stdoutfiles. This was driving me crazy.r? @alexcrichton