incr.comp.: Speed up span hashing by caching expansion context hashes. #46562
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors try |
|
⌛ Trying commit 1f8678acce1dfab84982dec5544460096a77a035 with merge b867f1811e7bb767d248b0ae46b8fabc16e83bed... |
kennytm
added
the
S-waiting-on-review
|
☀️ Test successful - status-travis |
|
@Mark-Simulacrum, could you do a perf run please? |
michaelwoerister
force-pushed
the
faster-span-hashing
branch
from
1f8678a to
fbcf14e
Compare
|
Perf run started. Sorry for the delay. |
|
Hey @Mark-Simulacrum, did that perf run ever finish? |
|
Yes. I generally forget to check back in; they auto-queue and finish within 4 hours at most, and the URLs are fairly easy to generate. Eventually this will be automated... |
|
Thanks @Mark-Simulacrum! I see now how I can compose these URLs myself. |
|
This is now ready for review, @nikomatsakis. |
|
☔ The latest upstream changes (presumably #46550) made this pull request unmergeable. Please resolve the merge conflicts. |
michaelwoerister
force-pushed
the
faster-span-hashing
branch
from
fbcf14e to
0b4c2cc
Compare
|
Rebased. |
|
@bors r+ |
|
📌 Commit 0b4c2cc has been approved by |
incr.comp.: Speed up span hashing by caching expansion context hashes. This PR fixes the performance regressions from #46338. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
incr.comp.: Revert hashing optimization that caused regression. This PR reverts part of #46562 which caused [a regression in the crossbeam rust-icci](https://travis-ci.org/rust-icci/crossbeam/builds/316574774) test. I don't know what the problem is exactly yet. Fortunately, the problematic part is also the less important one, so reverting should not have much impact on performance. r? @eddyb
This PR fixes the performance regressions from #46338.
r? @nikomatsakis