Point at var in short lived borrows instead of drop location #46719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
estebank
force-pushed
the
issue-39268
branch
from
48dcdef to
9aae600
Compare
kennytm
added
the
S-waiting-on-review
estebank
force-pushed
the
issue-39268
branch
4 times, most recently
from
9283c08 to
68ac119
Compare
|
r? @pnkfelix, who knows a lot more about borrow checking than me. |
|
This looks like a nice unification. I basically just cargo-culted the AST borrowck scheme when moving to MIR borrowck. |
|
r=me once @estebank has addressed the travis failure |
|
☔ The latest upstream changes (presumably #46641) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
force-pushed
the
issue-39268
branch
3 times, most recently
from
9a5a6e7 to
22a8b3c
Compare
estebank
added
S-waiting-on-author
estebank
force-pushed
the
issue-39268
branch
2 times, most recently
from
3b6d97d to
2bdaf0c
Compare
estebank
force-pushed
the
issue-39268
branch
from
2bdaf0c to
b562565
Compare
|
@bors r=pnkfelix |
|
📌 Commit b562565 has been approved by |
estebank
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 16, 2017
Point at var in short lived borrows instead of drop location For RLS' sake, point at the borrow location as primary span for short lived borrows, instead of the borrow drop location. Fix #39268.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RLS' sake, point at the borrow location as primary span for short lived borrows, instead of the borrow drop location.
Fix #39268.