Fix the len() method on LinearMap during popping #4672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
added a commit
that referenced
this pull request
Jan 29, 2013
Fix the len() method on LinearMap during popping
|
Thanks! (If you figure out how to reproduce it, feel free to submit another pull request with the test :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found while using
LinearMapthat it would often get its size out of sync with the actual number of elements. I found out that duringpopthe invocations ofinsert_opt_bucketmight increment the size even though nothing new was being inserted.I tried to create a simple test case or two, but I was unable to recreate the exact sequence of operations which would lead to the bug being triggered.