Skip to content

Generate "invalidates" facts when -Znll-facts is passed #50798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 5 commits into from
May 23, 2018
Merged

Generate "invalidates" facts when -Znll-facts is passed #50798

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f03518b
Framework and rough implementation for invalidates facts
sapphire-arches May 10, 2018
3b36fa8
Get closer to successful compilation
sapphire-arches May 15, 2018
0c902cf
Complete implementation of invalidates facts
sapphire-arches May 16, 2018
a82c097
Fix tidy errors
sapphire-arches May 16, 2018
965eef9
invalidates: properly handle terminators
sapphire-arches May 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/librustc_mir/borrow_check/nll/facts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ crate struct AllFacts {

// `region_live_at(R, P)` when the region R appears in a live variable at P
crate region_live_at: Vec<(RegionVid, LocationIndex)>,

// `invalidates(P, B)` when the borrow B is invalidated at point P
Copy link
Contributor

@nikomatsakis nikomatsakis May 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man I want to change from Borrow terminology to Loan. =)

crate invalidates: Vec<(LocationIndex, BorrowIndex)>,
}

impl AllFacts {
Expand Down Expand Up @@ -69,6 +72,7 @@ impl AllFacts {
killed,
outlives,
region_live_at,
invalidates,
])
}
Ok(())
Expand Down
Loading