Fix docs #5105
Closed
Fix docs #5105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this isn't actually calloc - it calls the malloc wrapper which no longer zeroes
it doesn't actually call calloc, so it's fairly pointless
… r=brson review? @brson Issue rust-lang#4524
Rename const_view to const_slice Renamed mut_view to mut_slice
…=catamorphism This is a natural extension of rust-lang#4887, and handles the following three cases: ~~~~ a line with only /s //////////////////////////////////////////// a line with only /s followed by whitespace //////////////////////////////////////////// a block comment with only *s between two /s /********************************/ ~~~~
I removed the unused wrappers methods named `calloc` because they relied on the malloc wrapper having a `bool zero = true` default parameter (which resulted in some accidental zeroing). Perhaps wrapping the actual calloc function would be useful, but I don't know of an existing use case that could use it so I just removed these. This gives an ~1% performance improvement for TreeMap, which does a lot of small allocations. Vectors use `realloc` which didn't zero before these changes so there's no measurable change in performance.
Removed hacky dependency on Round trait and generic infinity functions Removed generic-runtime-failure-depending-on-type behavior
Updated the rustc manpage based on the usage message for 0.6 (including -Z options). Also added an example showing how to compile with debug info. This targets incoming rather than master. rust-lang#4936 can be closed.
Removed Round impl for integers
compiles-as-is, but needs a snapshot to remove the `stage0`ed extfmt export in core. Closes rust-lang#4750
Now only `lib core/pipes.rs` has `#[allow(structural_records)]`. That can be removed after a snapshot.
…ion-depth-limit, r=catamorphism It appears that using deriving_eq/auto_encode on ASTs bumps up against the "gee this looks like infinite unfolding" limit of 10 in monomorphization. Increasing it to 30 seems to solve this problem for me.... Also, commenting and a few renames.
r? @pcwalton Local testing shows it's correctly putting things like ~(@10) in the managed heap. Not entirely sure how to turn such tests (which just log annihilation stats) into a regression test; we don't have much in the way of feedback from the annihilator. Open to suggestions. I will want to be keeping more detailed runtime stats on the gc as I proceed.
With the exception of three places where explicit self ran into borrowing errors. Will try those again once borrowing is refined.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Don't trigger [debug_assert_with_mut_call] on debug_assert!(_.await) Fixes rust-lang#5105 cc rust-lang#5112 changelog: Don't trigger [`debug_assert_with_mut_call`] on `debug_assert!(_.await)` and move it to nursery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in grammar: underscore, not minus, can appear amongst hex digits. I freely admit I have not taken the time to run a make check on this (trivial) patch.