Always check type_dependent_defs #51882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
approved these changes
Jun 28, 2018
| } | ||
| } else { | ||
| self.tcx.sess.delay_span_bug(expr.span, | ||
| "no type-dependent def for method call"); |
There was a problem hiding this comment.
There's no differentiation between this case and https://github.com/rust-lang/rust/pull/51882/files#diff-1651ba5b47f9ffa648d59265d3f94becR1018
There was a problem hiding this comment.
I figured this wouldn't really be a problem, because if it ever does occur, the stack trace should narrow it down precisely. I'm also hoping that if this case is ever hit, the error message won't be hit anyway, because a proper UI error should have occurred.
|
@bors r+ |
|
📌 Commit 4071adf has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 1, 2018
Always check type_dependent_defs Directly indexing into `type_dependent_defs` has caused multiple ICEs in the past (#46771, #49241, etc.) and is almost certainly responsible for #51798 too. This PR ensures we always check `type_dependent_defs` first, which should prevent any more of these (or at least make them easier to track down).
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly indexing into
type_dependent_defshas caused multiple ICEs in the past (#46771, #49241, etc.) and is almost certainly responsible for #51798 too. This PR ensures we always checktype_dependent_defsfirst, which should prevent any more of these (or at least make them easier to track down).