Skip to content

structured suggestion for renamed-and-removed-lints #52395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2018
Merged

structured suggestion for renamed-and-removed-lints #52395

merged 1 commit into from
Jul 16, 2018

Conversation

zackmdavis
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2018
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:53:04] ....................................................................................................
[00:53:08] ....................................................................................................
[00:53:12] ....................................................................................................
[00:53:15] ....................................................................................................
[00:53:20] ............................................FFF.F...................................................
[00:53:25] .....i..ii..........................................................................................
[00:53:28] ....................................................................................................
[00:53:31] ....................................................................................................
[00:53:34] .........................................................................................i..........

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@zackmdavis zackmdavis force-pushed the and_the_case_of_the_renamed_lint branch from 79fb4c7 to d351370 Compare July 15, 2018 05:09
estebank
estebank reviewed Jul 15, 2018
View reviewed changes
src/librustc/lint/levels.rs
new_name,
Applicability::MachineApplicable
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if we could add a suggestion to remove the lint, but getting the right span might be a bit of a pain (specially due to the possibility of multiple lints be present).

@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 15, 2018

📌 Commit d351370 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2018
@bors
Copy link
Collaborator

bors commented Jul 16, 2018

⌛ Testing commit d351370 with merge 1fa76a4...

bors added a commit that referenced this pull request Jul 16, 2018
@bors
Auto merge of #52395 - zackmdavis:and_the_case_of_the_renamed_lint, r…
1fa76a4 
…=estebank

structured suggestion for renamed-and-removed-lints

![lint_renamed](https://user-images.githubusercontent.com/1076988/42730470-f74688dc-87a9-11e8-8dfd-b3e1d70b0af8.png)

r? @estebank
@bors
Copy link
Collaborator

bors commented Jul 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing 1fa76a4 to master...

@bors bors merged commit d351370 into rust-lang:master Jul 16, 2018
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #52395!

Tested on commit 1fa76a4.
Direct link to PR: #52395

💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 16, 2018
@rust-highfive
📣 Toolstate changed by rust-lang/rust#52395!
057c23c 
Tested on commit rust-lang/rust@1fa76a4.
Direct link to PR: <rust-lang/rust#52395>

💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
@zackmdavis zackmdavis deleted the and_the_case_of_the_renamed_lint branch July 16, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zackmdavis @rust-highfive @estebank @bors