Add doc ui tests

.gitignore

@@ -109,3 +109,5 @@ version.texi
 
 no_llvm_build
 
+**node_modules/
+**doc-ui/.lock

src/bootstrap/builder.rs

@@ -421,6 +421,7 @@ impl<'a> Builder<'a> {
                 test::Clippy,
                 test::RustdocJS,
                 test::RustdocTheme,
+                test::DocUI,
                 // Run bootstrap close to the end as it's unlikely to fail
                 test::Bootstrap,
                 // Run run-make last, since these won't pass without make on Windows

src/bootstrap/test.rs

@@ -584,6 +584,70 @@ impl Step for RustdocJS {
     }
 }
 
+#[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
+pub struct DocUI {
+    pub host: Interned<String>,
+    pub target: Interned<String>,
+}
+
+impl Step for DocUI {
+    type Output = ();
+    const DEFAULT: bool = true;
+    const ONLY_HOSTS: bool = true;
+
+    fn should_run(run: ShouldRun) -> ShouldRun {
+        run.path("src/test/doc-ui")
+    }
+
+    fn make_run(run: RunConfig) {
+        run.builder.ensure(DocUI {
+            host: run.host,
+            target: run.target,
+        });
+    }
+
+    fn run(self, builder: &Builder) {
+        if let Some(ref nodejs) = builder.config.nodejs {
+            let mut found_puppeteer = false;
+            // Check if puppeteer is installed locally.
+            if let Ok(output) = Command::new("npm")
+                                        .args(&["ls", "puppeteer", "puppeteer-core"])
+                                        .current_dir("src/tools/doc-ui")
+                                        .output() {
+                found_puppeteer = String::from_utf8_lossy(&output.stdout).contains("puppeteer");
+            }
+            if !found_puppeteer {
+                // Check if puppeteer is installed "globally".
+                if let Ok(output) = Command::new("npm")
+                                            .args(&["ls", "-g", "puppeteer", "puppeteer-core"])
+                                            .output() {
+                    found_puppeteer = String::from_utf8_lossy(&output.stdout).contains("puppeteer");
+                }
+            }
+            if !found_puppeteer {
+                let mut command = Command::new(nodejs);
+                command.args(&["src/tools/doc-ui/script.js",
+                               &*self.host,
+                               &builder.top_stage.to_string()]);
+                builder.ensure(::doc::Std {
+                    target: self.target,
+                    stage: builder.top_stage,
+                });
+                builder.run(&mut command);
+            } else {
+                builder.info(&format!(
+                    "No puppeteer found (maybe try installing it with `npm install puppeteer`?), \
+                     skipping \"src/test/doc-ui\" tests"
+                ));
+            }
+        } else {
+            builder.info(&format!(
+                "No nodejs found, skipping \"src/test/doc-ui\" tests"
+            ));
+        }
+    }
+}
+
 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
 pub struct RustdocUi {
     pub host: Interned<String>,

src/test/doc-ui/lib/lib.rs

@@ -0,0 +1,14 @@
+// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+pub struct Foo {
+    pub damn: u32,
+    pub foo: Option<i8>,
+}

src/test/doc-ui/struct-syntax.js

@@ -0,0 +1,13 @@
+// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+var TEST = {
+    "path": "struct.Foo.html",
+};