Added pointer checking to sanity checks - #53831
Conversation
|
cc @RalfJung |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☔ The latest upstream changes (presumably #53779) made this pull request unmergeable. Please resolve the merge conflicts. |
d595ef6 to
d396004
Compare
|
@bors r+ |
|
📌 Commit d39600432c1079352481dc31b4ab7d293fa8cb22 has been approved by |
|
@bors r- |
|
@bors try let's crater this first. This is a breaking change for code that drives dangerously close to UB |
|
⌛ Trying commit d39600432c1079352481dc31b4ab7d293fa8cb22 with merge aa245a5862056b681d2ccdb178f58891108cd3a6... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
90851c0 to
de0cd23
Compare
|
You removed two ui tests, didn't they come with |
|
@craterbot run start=master#1114ab684fbad001c4e580326d8eb4d8c4e917d3 end=try#aa245a5862056b681d2ccdb178f58891108cd3a6 mode=check-only |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
@RalfJung Those two tests were actually flagged with |
|
This experiment is running quite slowly on crater, maybe it would be best to also do a perf run?
|
|
Insufficient permissions to issue commands to rust-timer. |
|
@rust-timer build aa245a5862056b681d2ccdb178f58891108cd3a6 I would be surprised, but let's see. |
|
Success: Queued aa245a5862056b681d2ccdb178f58891108cd3a6 with parent 1114ab6, comparison URL. |
|
🎉 Experiment
|
|
Some noise in the timer, mostly even positive Spurious regression in the crater run (thread '' panicked at 'procedural macro API is used outside of a procedural macro', libproc_macro/lib.rs:1295:13) @bors r+ |
|
📌 Commit de0cd23 has been approved by |
Added pointer checking to sanity checks r? @oli-obk
|
☀️ Test successful - status-appveyor, status-travis |
r? @oli-obk