Skip to content

[beta] rustdoc: disable blanket impl collection #54104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuietMisdreavus
Copy link
Member

Beta patch for #52873 so we don't propagate the ICE into stable. (This time on the correct branch!)

r? @rust-lang/rustdoc @Mark-Simulacrum

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ p=10

(Presuming that this code change is fine since it's just removing things and tests should pass).

@bors
Copy link
Collaborator

bors commented Sep 10, 2018

📌 Commit c017586 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2018
@bors
Copy link
Collaborator

bors commented Sep 10, 2018

⌛ Testing commit c017586 with merge 6fdf1db...

bors added a commit that referenced this pull request Sep 10, 2018
…Simulacrum

[beta] rustdoc: disable blanket impl collection

Beta patch for #52873 so we don't propagate the ICE into stable. (This time on the correct branch!)

r? @rust-lang/rustdoc @Mark-Simulacrum
@bors
Copy link
Collaborator

bors commented Sep 11, 2018

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2018
@Mark-Simulacrum Mark-Simulacrum merged commit c017586 into rust-lang:beta Sep 11, 2018
@QuietMisdreavus QuietMisdreavus deleted the beta-disable-blankets branch October 2, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants