Skip to content

Conversation

@ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Oct 5, 2018

It's just Into<Cow<...>> and the applicable methods already exist for Vec/[T] and String/str.

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2018
@pnkfelix
Copy link
Contributor

pnkfelix commented Oct 7, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 7, 2018

📌 Commit c30ce35 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2018
@bors
Copy link
Collaborator

bors commented Oct 8, 2018

⌛ Testing commit c30ce35 with merge 25a75a4...

bors added a commit that referenced this pull request Oct 8, 2018
Cleanup: remove graphviz::IntoCow

It's just `Into<Cow<...>>` and the applicable methods already exist for `Vec`/`[T]` and `String`/`str`.
@bors
Copy link
Collaborator

bors commented Oct 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing 25a75a4 to master...

@bors bors merged commit c30ce35 into rust-lang:master Oct 8, 2018
@ljedrz ljedrz deleted the kill_graphviz_intocow branch October 8, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants