-
Notifications
You must be signed in to change notification settings - Fork 13.3k
improve search tabs look #55126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve search tabs look #55126
Conversation
Thank you for trying out changes! The use of negative space tabs idea is clever, and does give more context to their purpose. The minimalism of the single line previously was clean, at least for those who know its there, but that subtlety might've been what made it easy to overlook. Currently in the above tabs, the text might benefit with some extra vertical breathing room. I was in the middle of a variation of your negative space idea before realizing I had copied Firefox's tabs.. |
Well, they look better than what I did so I can totally go for it (and I will)! |
0af9430
to
5e70b7c
Compare
Ohhhh, it worked out on light theme too! |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Ah woups, forgot a css rule apparently... |
5e70b7c
to
dc52425
Compare
Wow, this looks really nice now! @bors r+ rollup |
📌 Commit dc52425 has been approved by |
…dreavus improve search tabs look Fixes #55056.   With this, I think it'll be more obvious. cc @memoryruins r? @QuietMisdreavus
☀️ Test successful - status-appveyor, status-travis |
Fixes #55056.
With this, I think it'll be more obvious.
cc @memoryruins
r? @QuietMisdreavus