Skip to content

improve search tabs look #55126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #55056.

screenshot from 2018-10-16 19-06-48

screenshot from 2018-10-16 19-09-39

With this, I think it'll be more obvious.

cc @memoryruins

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2018
@memoryruins
Copy link
Contributor

memoryruins commented Oct 17, 2018

Thank you for trying out changes! The use of negative space tabs idea is clever, and does give more context to their purpose. The minimalism of the single line previously was clean, at least for those who know its there, but that subtlety might've been what made it easy to overlook. Currently in the above tabs, the text might benefit with some extra vertical breathing room.

I was in the middle of a variation of your negative space idea before realizing I had copied Firefox's tabs..

firedocs

@GuillaumeGomez
Copy link
Member Author

Well, they look better than what I did so I can totally go for it (and I will)!

@GuillaumeGomez
Copy link
Member Author

Here's the current look:

screen shot 2018-10-21 at 16 38 42

screen shot 2018-10-21 at 16 38 48

@memoryruins
Copy link
Contributor

Ohhhh, it worked out on light theme too!

@rust-highfive
Copy link
Contributor

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:53:56] .................................................................................................... 2200/4659
[00:54:00] .....................................i.............................................................. 2300/4659
[00:54:04] .................................................................................................... 2400/4659
[00:54:08] .................................................................................................... 2500/4659
[00:54:11] ....................................................iiiiiiiii....................................... 2600/4659
[00:54:18] .................................................................................................... 2800/4659
[00:54:22] .................................................................................................... 2900/4659
[00:54:25] ..................................................................................i................. 3000/4659
[00:54:27] .................................................................................................... 3100/4659
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:07:59] 
[01:07:59] running 111 tests
[01:08:02] i..ii...iii.......i...i.........i..iii...........i.....i.....ii...i.i.ii..............i...ii..ii.i.. 100/111
[01:08:02] ..iiii.....
[01:08:02] 
[01:08:02]  finished in 3.619
[01:08:02] travis_fold:end:test_codegen

---
[01:42:30] travis_time:end:stage0-rustdoc-themes:start=1540139169611373121,finish=1540139170641376269,duration=1030003148

[01:42:30] rustdoc: [theme-checker] Starting tests!
[01:42:30]  - Checking "/checkout/src/librustdoc/html/static/themes/dark.css"... FAILED
[01:42:30]   Missing "#titles > div:not(:last-child)" rule
[01:42:30] 
[01:42:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rustdoc-themes" "/checkout/obj/build/bootstrap/debug/rustdoc" "/checkout/src/librustdoc/html/static/themes"
[01:42:30] expected success, got: exit code: 1
[01:42:30] 
[01:42:30] 
[01:42:30] 
[01:42:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:42:30] Build completed unsuccessfully in 0:53:22
[01:42:30] Makefile:58: recipe for target 'check' failed
[01:42:30] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:017bab05
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@GuillaumeGomez
Copy link
Member Author

Ah woups, forgot a css rule apparently...

@QuietMisdreavus
Copy link
Member

Wow, this looks really nice now!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 21, 2018

📌 Commit dc52425 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2018
bors added a commit that referenced this pull request Oct 22, 2018
@bors
Copy link
Collaborator

bors commented Oct 22, 2018

⌛ Testing commit dc52425 with merge 5481485...

@bors
Copy link
Collaborator

bors commented Oct 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 5481485 to master...

@bors bors merged commit dc52425 into rust-lang:master Oct 22, 2018
@GuillaumeGomez GuillaumeGomez deleted the improve-search-tabs branch October 22, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants