Skip to content

reword #[test] attribute error on fn items #55923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libsyntax_ext/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub fn expand_test_or_bench(
if let Annotatable::Item(i) = item { i }
else {
cx.parse_sess.span_diagnostic.span_fatal(item.span(),
"#[test] attribute is only allowed on fn items").raise();
"#[test] attribute is only allowed on non associated functions").raise();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase non associated functions as free functions to avoid the negative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a simple search of "rust free functions" on duckduckgo or "free functions" on the rust book has no results while "associated functions" gives you the expected page, that's why I chose that phrase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly the page in the book is quite wrong in that it defines "associated function" as a non-method inside an implementation (trait/inherent). Thus, by saying "non-associated function", by the incorrect definition in the book you are stating that #[test] is allowed on methods. Given this, I think if you want to impart a correct error you need to say something like:

"#[test] attribute is only allowed on free functions without arguments"

or:

"#[test] attribute is only allowed on no-argument functions outside implementations"

};

if let ast::ItemKind::Mac(_) = item.node {
Expand Down
29 changes: 29 additions & 0 deletions src/test/ui/test-attr-non-associated-functions.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// #[test] attribute is not allowed on associated functions or methods
// reworded error message
// compile-flags:--test

struct A {}

impl A {
#[test]
fn new() -> A { //~ ERROR #[test] attribute is only allowed on non associated functions
A {}
}
}

#[test]
fn test() {
let _ = A::new();
}

fn main() {}
10 changes: 10 additions & 0 deletions src/test/ui/test-attr-non-associated-functions.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
error: #[test] attribute is only allowed on non associated functions
--> $DIR/test-attr-non-associated-functions.rs:19:5
|
LL | / fn new() -> A { //~ ERROR #[test] attribute is only allowed on non associated functions
LL | | A {}
LL | | }
| |_____^

error: aborting due to previous error