Skip to content

[stable] 1.31.1 point release #56911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 18, 2018
Merged

[stable] 1.31.1 point release #56911

merged 5 commits into from
Dec 18, 2018

Conversation

pietroalbini
Copy link
Member

Rust 1.31.1 is scheduled to be released on Thursday 20th, with the following changes:

r? @Mark-Simulacrum
cc @rust-lang/core @rust-lang/release

@pietroalbini pietroalbini added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Dec 17, 2018
@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!
  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2018
@rust-highfive

This comment has been minimized.

@Mark-Simulacrum
Copy link
Member

r=me with Travis passing

@rust-highfive

This comment has been minimized.

@pietroalbini
Copy link
Member Author

@bors r=Mark-Simulacrum p=1000

@bors
Copy link
Collaborator

bors commented Dec 17, 2018

📌 Commit 2c45cb881449980bfd5ae505522b384051bc89b3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2018
@bors
Copy link
Collaborator

bors commented Dec 17, 2018

⌛ Testing commit 2c45cb881449980bfd5ae505522b384051bc89b3 with merge da4c4e0d08039484381c6ca104d3c7a1ff36a76e...

@bors
Copy link
Collaborator

bors commented Dec 17, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2018
@pietroalbini
Copy link
Member Author

Ping @nrc, can you look at the test suite failure for RLS?

@Mark-Simulacrum

This comment has been minimized.

@pietroalbini
Copy link
Member Author

Updated the RLS submodule to fix the failing test.

@bors r=Mark-Simulacrum p=1000

@bors
Copy link
Collaborator

bors commented Dec 17, 2018

📌 Commit 440c971 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2018
@bors
Copy link
Collaborator

bors commented Dec 18, 2018

⌛ Testing commit 440c971 with merge f1420a544995da9986d01bfa2a1569c4d640f5eb...

@bors
Copy link
Collaborator

bors commented Dec 18, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2018
@rust-highfive

This comment has been minimized.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2018
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 18, 2018
@pietroalbini
Copy link
Member Author

Thanks @Xanewok for fixing the RLS test!

@bors r=Mark-Simulacrum p=1000

@bors
Copy link
Collaborator

bors commented Dec 18, 2018

📌 Commit ef6c008 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2018
@bors
Copy link
Collaborator

bors commented Dec 18, 2018

⌛ Testing commit ef6c008 with merge 642e063...

bors added a commit that referenced this pull request Dec 18, 2018
[stable] 1.31.1 point release

Rust 1.31.1 is scheduled to be released on Thursday 20th, with the following changes:

* #56562: Update libc version required by rustc *(different patch made by me)*
* #56615: Update the book to fix some edition-related bugs
* rls submodule update to [`b379ef7`](rust-lang/rls@b379ef7), including:
  * rust-lang/rls#1170: Fix for common infinte loop regression
  * rust-lang/rls#1171: Can't jump to std defs

r? @Mark-Simulacrum
cc @rust-lang/core @rust-lang/release
@bors
Copy link
Collaborator

bors commented Dec 18, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 642e063 to stable...

@bors bors merged commit ef6c008 into stable Dec 18, 2018
@pietroalbini pietroalbini deleted the stable-1.31.1 branch December 18, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants