Update book submodule #58709

kornelski · 2019-02-24T18:00:26Z

Updates the book to the latest commit

This is to include documentation SEO fix ASAP.

rust-highfive · 2019-02-24T18:00:28Z

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-02-24T18:00:29Z

⚠️ Warning ⚠️

These commits modify submodules.

rust-highfive · 2019-02-24T20:01:16Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1c13ede8:start=1551032458755014020,finish=1551032460897623872,duration=2142609852
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:13:24] 
[01:13:24] running 119 tests
[01:13:49] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:13:53] i......iii.i.....ii
[01:13:53] 
[01:13:53]  finished in 29.533
[01:13:53] travis_fold:end:test_debuginfo

---
[01:39:49] travis_fold:end:stage0-linkchecker

[01:39:49] travis_time:end:stage0-linkchecker:start=1551038459193836386,finish=1551038461376226718,duration=2182390332

[01:39:50] book/second-edition/ch07-00-modules.html:31: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/second-edition/ch07-03-importing-names-with-use.html:31: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/second-edition/print.html:206: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/second-edition/print.html:213: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/second-edition/print.html:220: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/second-edition/print.html:227: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/second-edition/ch07-01-mod-and-the-filesystem.html:31: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/second-edition/ch07-02-controlling-visibility-with-pub.html:31: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/crates-and-modules.html:47: broken link - book/ch07-00-packages-crates-and-modules.html
[01:39:50] book/print.html:2919: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/print.html:9846: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/print.html:10736: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/first-edition/type-aliases.html:60: broken link fragment `#type-aliases-create-type-synonyms` pointing to `book/ch19-04-advanced-types.html`
[01:39:50] book/first-edition/crates-and-modules.html:60: broken link - book/ch07-00-packages-crates-and-modules.html
[01:39:50] book/first-edition/print.html:256: broken link - book/ch07-00-packages-crates-and-modules.html
[01:39:50] book/first-edition/print.html:277: broken link fragment `#type-aliases-create-type-synonyms` pointing to `book/ch19-04-advanced-types.html`
[01:39:50] book/ch11-03-test-organization.html:316: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/ch04-01-what-is-ownership.html:290: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:50] book/ch11-01-writing-tests.html:365: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:52] std/index.html:9: broken link - book/ch07-02-modules-and-use-to-control-scope-and-privacy.html
[01:39:57] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:41:9
[01:39:57] 
[01:39:57] 
[01:39:57] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:39:57] expected success, got: exit code: 101
[01:39:57] expected success, got: exit code: 101
[01:39:57] 
[01:39:57] 
[01:39:57] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:39:57] Build completed unsuccessfully in 0:38:12
[01:39:57] make: *** [check] Error 1
[01:39:57] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:3ad4d921
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb 24 20:01:09 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-02-25T01:05:56Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1048a0bb:start=1551050439465941504,finish=1551050442031584920,duration=2565643416
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
    86% |███████████████████████████▊    | 102kB 50.7MB/s eta 0:00:01
    95% |██████████████████████████████▌ | 112kB 59.8MB/s eta 0:00:01
    100% |████████████████████████████████| 122kB 38.9MB/s 
Collecting jmespath<1.0.0,>=0.7.1 (from botocore==1.12.101->awscli)
  Downloading https://files.pythonhosted.org/packages/83/94/7179c3832a6d45b266ddb2aac329e101367fbdb11f425f13771d27f225bb/jmespath-0.9.4-py2.py3-none-any.whl
  Downloading https://files.pythonhosted.org/packages/41/17/c62faccbfbd163c7f57f3844689e3a78bae1f403648a6afb1d0866d87fbb/python_dateutil-2.8.0-py2.py3-none-any.whl (226kB)
    4% |█▌                              | 10kB 25.7MB/s eta 0:00:01
    9% |███                             | 20kB 32.2MB/s eta 0:00:01
    13% |████▍                           | 30kB 39.6MB/s eta 0:00:01
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:17:37] 
[01:17:37] running 119 tests
[01:18:03] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:18:08] i......iii.i.....ii
[01:18:08] 
[01:18:08]  finished in 30.413
[01:18:08] travis_fold:end:test_debuginfo

---
[01:44:50] travis_fold:end:stage0-linkchecker

[01:44:50] travis_time:end:stage0-linkchecker:start=1551056740978954463,finish=1551056743080794043,duration=2101839580

[01:44:50] book/second-edition/ch07-03-importing-names-with-use.html:31: broken link fragment `#the-use-keyword-to-bring-paths-into-a-scope.html` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/second-edition/print.html:220: broken link fragment `#using-the-pub-keyword-to-make-items-public.html` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/second-edition/print.html:227: broken link fragment `#the-use-keyword-to-bring-paths-into-a-scope.html` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/second-edition/ch07-02-controlling-visibility-with-pub.html:31: broken link fragment `#using-the-pub-keyword-to-make-items-public.html` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/crates-and-modules.html:47: broken link - book/ch07-00-packages-crates-and-modules.html
[01:44:50] book/print.html:2919: broken link fragment `#paths-for-referring-to-an-item-in-the-module-tree` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/print.html:9846: broken link fragment `#modules-as-the-privacy-boundary` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/print.html:10736: broken link fragment `#separating-modules-into-different-files` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/first-edition/type-aliases.html:60: broken link fragment `#type-aliases-create-type-synonyms` pointing to `book/ch19-04-advanced-types.html`
[01:44:50] book/first-edition/crates-and-modules.html:60: broken link - book/ch07-00-packages-crates-and-modules.html
[01:44:50] book/first-edition/print.html:256: broken link - book/ch07-00-packages-crates-and-modules.html
[01:44:50] book/first-edition/print.html:277: broken link fragment `#type-aliases-create-type-synonyms` pointing to `book/ch19-04-advanced-types.html`
[01:44:50] book/ch11-03-test-organization.html:316: broken link fragment `#separating-modules-into-different-files` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/ch04-01-what-is-ownership.html:290: broken link fragment `#paths-for-referring-to-an-item-in-the-module-tree` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:50] book/ch11-01-writing-tests.html:365: broken link fragment `#modules-as-the-privacy-boundary` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:52] std/index.html:9: broken link fragment `#the-use-keyword-to-bring-paths-into-a-scope` pointing to `book/ch07-02-defining-modules-to-control-scope-and-privacy.html`
[01:44:57] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:41:9
[01:44:57] 
[01:44:57] 
[01:44:57] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:44:57] expected success, got: exit code: 101
[01:44:57] expected success, got: exit code: 101
[01:44:57] 
[01:44:57] 
[01:44:57] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:44:57] Build completed unsuccessfully in 0:39:33
[01:44:57] make: *** [check] Error 1
[01:44:57] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:002eb3f0
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Feb 25 01:05:51 UTC 2019
---
travis_time:end:0171fabc:start=1551056753021834281,finish=1551056753027321611,duration=5487330
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a908986
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kornelski · 2019-02-25T03:40:55Z

Waiting for rust-lang/book#1832

QuietMisdreavus · 2019-02-25T15:59:16Z

Looks like that last force-push includes the last linked PR, so...

@bors r+ p=1

bors · 2019-02-25T15:59:17Z

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

QuietMisdreavus · 2019-02-25T16:00:59Z

Oh whoops, missed the WIP marker. Is this ready to go? If so, please update the title of the PR so i can re-r+.

kornelski · 2019-02-25T21:51:26Z

Yup, it's ready now.

QuietMisdreavus · 2019-02-25T22:11:37Z

Thanks!

@bors r+

bors · 2019-02-25T22:11:37Z

📌 Commit 19c302c has been approved by QuietMisdreavus

bors · 2019-02-26T08:59:22Z

⌛ Testing commit 19c302c with merge 5f945f178000329cc2686e2079f29a28a73e8373...

bors · 2019-02-26T09:32:13Z

💔 Test failed - checks-travis

rust-highfive · 2019-02-26T09:32:14Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Attempting to download s3://rust-lang-ci-sccache2/docker/7e1a0f6dbf7ee5eb0f689d3f3f0b0c18b1a9c99aaacc2a649ce33a6db602dde1d880b783741255f4fb7da1afa8a7b1e7897822d59f692a8c90e11f791375e7c7
[00:00:20] Attempting with retry: curl -y 30 -Y 10 --connect-timeout 30 -f -L -C - -o /tmp/rustci_docker_cache https://s3-us-west-1.amazonaws.com/rust-lang-ci-sccache2/docker/7e1a0f6dbf7ee5eb0f689d3f3f0b0c18b1a9c99aaacc2a649ce33a6db602dde1d880b783741255f4fb7da1afa8a7b1e7897822d59f692a8c90e11f791375e7c7
[00:00:20]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[00:00:20]                                  Dload  Upload   Total   Spent    Left  Speed
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kornelski · 2019-02-26T14:41:58Z

Looks like a network error rather than a test failure

QuietMisdreavus · 2019-02-26T14:50:12Z

@bors retry (stalled build)

bors · 2019-02-27T07:54:06Z

⌛ Testing commit 19c302c with merge f5b5f92...

Update book submodule Updates the book to the latest commit This is to include [documentation SEO fix](rust-lang/book#1788) ASAP.

bors · 2019-02-27T10:43:31Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: QuietMisdreavus
Pushing f5b5f92 to master...

rust-highfive assigned QuietMisdreavus Feb 24, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2019

kornelski changed the title ~~Update book submodule~~ [WIP] Update book submodule Feb 24, 2019

kornelski force-pushed the book branch from 4561b69 to 903986c Compare February 25, 2019 01:35

kornelski mentioned this pull request Feb 25, 2019

Update links to ch07-02 rust-lang/book#1832

Merged

Update book submodule

19c302c

kornelski force-pushed the book branch from 903986c to 19c302c Compare February 25, 2019 13:31

kornelski changed the title ~~[WIP] Update book submodule~~ Update book submodule Feb 25, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2019

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 26, 2019

bors added a commit that referenced this pull request Feb 27, 2019

Auto merge of #58709 - kornelski:book, r=QuietMisdreavus

f5b5f92

Update book submodule Updates the book to the latest commit This is to include [documentation SEO fix](rust-lang/book#1788) ASAP.

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 27, 2019

bors merged commit 19c302c into rust-lang:master Feb 27, 2019

kornelski deleted the book branch February 27, 2019 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update book submodule #58709

Update book submodule #58709

kornelski commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

rust-highfive commented Feb 25, 2019

kornelski commented Feb 25, 2019

QuietMisdreavus commented Feb 25, 2019

bors commented Feb 25, 2019

QuietMisdreavus commented Feb 25, 2019

kornelski commented Feb 25, 2019

QuietMisdreavus commented Feb 25, 2019

bors commented Feb 25, 2019

bors commented Feb 26, 2019

bors commented Feb 26, 2019

rust-highfive commented Feb 26, 2019

kornelski commented Feb 26, 2019

QuietMisdreavus commented Feb 26, 2019

bors commented Feb 27, 2019

bors commented Feb 27, 2019

Update book submodule #58709

Update book submodule #58709

Conversation

kornelski commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

rust-highfive commented Feb 24, 2019

rust-highfive commented Feb 25, 2019

kornelski commented Feb 25, 2019

QuietMisdreavus commented Feb 25, 2019

bors commented Feb 25, 2019

QuietMisdreavus commented Feb 25, 2019

kornelski commented Feb 25, 2019

QuietMisdreavus commented Feb 25, 2019

bors commented Feb 25, 2019

bors commented Feb 26, 2019

bors commented Feb 26, 2019

rust-highfive commented Feb 26, 2019

kornelski commented Feb 26, 2019

QuietMisdreavus commented Feb 26, 2019

bors commented Feb 27, 2019

bors commented Feb 27, 2019