Skip to content

Add const generics to rustdoc #59170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 23, 2019
Merged

Add const generics to rustdoc #59170

merged 10 commits into from
Mar 23, 2019
+156 −117

Conversation

varkor
Copy link
Member

@varkor varkor commented Mar 13, 2019

Split out from #53645. This work is a collaborative effort with @yodaldevoid.

The FIXMEs are waiting on a refactor to LazyConst. I'll address these in a follow up, but I thought it would be better to implement the rest now to avoid bitrot.

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2019
@varkor varkor mentioned this pull request Mar 13, 2019
Merged
@eddyb
Copy link
Member

eddyb commented Mar 14, 2019

r=me with the nit fixed, and maybe a review from @QuietMisdreavus too

@bors
Copy link
Collaborator

bors commented Mar 15, 2019

☔ The latest upstream changes (presumably #58140) made this pull request unmergeable. Please resolve the merge conflicts.

QuietMisdreavus
QuietMisdreavus reviewed Mar 18, 2019
View reviewed changes
Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments. Thanks for writing this up!

varkor and others added 10 commits March 18, 2019 19:38
@varkor varkor force-pushed the const-generics-rustdoc branch from f065096 to 9bc5811 Compare March 18, 2019 19:47
QuietMisdreavus
QuietMisdreavus approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! r=me+eddyb when travis is green.

@varkor
Copy link
Member Author

varkor commented Mar 18, 2019

@bors r=QuietMisdreavus,eddyb

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

📌 Commit 9bc5811 has been approved by QuietMisdreavus,eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2019
@varkor
Copy link
Member Author

varkor commented Mar 19, 2019

@bors rollup

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 22, 2019
Closed
@Centril Centril mentioned this pull request Mar 22, 2019
Merged
@bors bors merged commit 9bc5811 into rust-lang:master Mar 23, 2019
@varkor varkor deleted the const-generics-rustdoc branch March 27, 2019 11:33
@varkor varkor mentioned this pull request May 2, 2019
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb left review comments

@QuietMisdreavus QuietMisdreavus QuietMisdreavus approved these changes

Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Milestone
No milestone