Skip to content

Update cmake, cc and compiler_builtins for VS 2019 support #59799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 46 additions & 46 deletions Cargo.lock

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/bootstrap/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ test = false

[dependencies]
build_helper = { path = "../build_helper" }
cmake = "0.1.23"
cmake = "0.1.38"
filetime = "0.2"
num_cpus = "1.0"
getopts = "0.2"
cc = "1.0.1"
cc = "1.0.35"
libc = "0.2"
serde = "1.0.8"
serde_derive = "1.0.8"
Expand Down
5 changes: 5 additions & 0 deletions src/bootstrap/sanity.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ pub fn check(build: &mut Build) {
continue;
}

// We don't use a C compiler on wasm32
if target.contains("wasm32") {
continue;
}

if !build.config.dry_run {
cmd_finder.must_have(build.cc(*target));
if let Some(ar) = build.ar(*target) {
Expand Down
5 changes: 4 additions & 1 deletion src/bootstrap/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,10 @@ impl Step for Compiletest {
// Also provide `rust_test_helpers` for the host.
builder.ensure(native::TestHelpers { target: compiler.host });

builder.ensure(native::TestHelpers { target });
// wasm32 can't build the test helpers
if !target.contains("wasm32") {
builder.ensure(native::TestHelpers { target });
}
builder.ensure(RemoteCopyLibs { compiler, target });

let mut cmd = builder.tool_cmd(Tool::Compiletest);
Expand Down
2 changes: 1 addition & 1 deletion src/liballoc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ path = "lib.rs"

[dependencies]
core = { path = "../libcore" }
compiler_builtins = { version = "0.1.0", features = ['rustc-dep-of-std'] }
compiler_builtins = { version = "0.1.10", features = ['rustc-dep-of-std'] }

[dev-dependencies]
rand = "0.6"
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_asan/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test = false

[build-dependencies]
build_helper = { path = "../build_helper" }
cmake = "0.1.18"
cmake = "0.1.38"

[dependencies]
alloc = { path = "../liballoc" }
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_lsan/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test = false

[build-dependencies]
build_helper = { path = "../build_helper" }
cmake = "0.1.18"
cmake = "0.1.38"

[dependencies]
alloc = { path = "../liballoc" }
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_msan/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test = false

[build-dependencies]
build_helper = { path = "../build_helper" }
cmake = "0.1.18"
cmake = "0.1.38"

[dependencies]
alloc = { path = "../liballoc" }
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_tsan/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test = false

[build-dependencies]
build_helper = { path = "../build_helper" }
cmake = "0.1.18"
cmake = "0.1.38"

[dependencies]
alloc = { path = "../liballoc" }
Expand Down