Continue evaluating after missing main#59903
Conversation
|
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -939,7 +940,10 @@ fn analysis<'tcx>( | |||
|
|
|||
| // Abort so we don't try to construct MIR with liveness errors. | |||
| // We also won't want to continue with errors from rvalue promotion | |||
There was a problem hiding this comment.
well, we actually want to, but that's not really a problem of this PR. Have you checked how bad the fallout is if we remove this abort_if_errors?
There was a problem hiding this comment.
I believe that there were some useless errors coming from const evaluation, but those might have come from removing the later check at https://github.com/rust-lang/rust/pull/59903/files/13a05a27e9a5747cad090b1670c0a6b0baa624b9#diff-24c5c945888bb0d041e769bfb852de6cR976
There was a problem hiding this comment.
Can you check? I'd rather remove it entirely. Const eval should not evaluate MIR with typeck errors or borrowck errors.
There was a problem hiding this comment.
@oli-obk most of the extra errors are not too bad, but src/test/ui/consts/match_ice.rs starts ICEing again. I'll need to dig deeper to fix the ICE and would like to remove the duplicated errors/warnings before merging that change, but it is certainly doable.
There was a problem hiding this comment.
Hmm... Those look like deeper issues to me where some things should be querified more or just produce dummy values in case of errors. Please open an issue linking to the fallout of 8395dbd and mentioning the problems.
|
@bors r+ We'll do the full fix later, needs some investigation |
|
📌 Commit 13a05a2 has been approved by |
bors
added
S-waiting-on-bors
Continue evaluating after missing main
|
@oli-obk, made one further change in a separate branch that gets rid of the ICE, but I'm not sure it is the right solution. |
Continue evaluating after missing main
Continue evaluating after missing main
Rollup of 6 pull requests Successful merges: - #59717 (improve docs for std::hint::unreachable_unchecked()) - #59903 (Continue evaluating after missing main) - #59973 (Fix rustdoc sidebar z-index) - #59992 (rustdoc: use --static-root-path for settings.js) - #59993 (include mode in unused binding suggestion span) - #60000 (Add repo-specific triagebot configuration) Failed merges: r? @ghost
4 participants
No description provided.