-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update submodules Clippy, rls, miri #59916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bors r+ p=5 (would be good to get it merged before the nightly build) |
📌 Commit 8d1b203 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
✌️ @flip1995 can now approve this pull request |
⌛ Testing commit 8d1b203 with merge 17961af08f72a731efff1e4413355e05e096d42e... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Huh? These deps got pulled into the
|
rust/src/tools/tidy/src/deps.rs Line 25 in 5b96425
|
These deps got pulled in by running `cargo update -p rls`
Tidy passes now. Sorry for not checking. Let's hope that this goes through. @bors r+ |
📌 Commit 824a04d has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Still doesn't pass... I have to catch a train now. I don't know if I can fix this today, it would be great if someone else can take over, otherwise I'll do it first thing in the morning. @bors r- |
I think I know what is going on.
Dropping Miri would be easiest solution. |
That's weird... As I understand this, the features in that Cargo.toml are to work around tools requiring different features by enabling the sum of all the features necessary, unconditionally (relying on the fact that features are additive). I'll try to omit Miri for now |
It seems that rand_core:0.3.0 needs to be bumped: BurntSushi/quickcheck#228 |
Update submodules (Clippy, RLS) Basically #59916 with one fix applied to make it build
cc #59227
r? @Xanewok