Skip to content

Change suggestion of field when not in self context #60061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2019
Merged

Change suggestion of field when not in self context #60061

merged 3 commits into from
Apr 19, 2019

Conversation

estebank
Copy link
Contributor

Fix #60057.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2019
@estebank
Copy link
Contributor Author

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned eddyb Apr 18, 2019
@estebank
Copy link
Contributor Author

CC @nagisa

davidtwco
davidtwco approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

📌 Commit 37d4d38e3d6e934db6852de4a4a3983a0f16047d has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
petrochenkov
petrochenkov reviewed Apr 18, 2019
View reviewed changes
src/test/ui/class-missing-self.stderr
@@ -2,7 +2,7 @@ error[E0425]: cannot find value `meows` in this scope
--> $DIR/class-missing-self.rs:9:7
|
LL | meows += 1;
| ^^^^^ help: try: `self.meows`
| ^^^^^ help: you might have meant to use the available field: `self.meows`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(As the author of that "try", I still prefer less wordy labels.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The longer text is there for people that come from languages like Java, where implicit this. Having the longer text let us differentiate between fields and bindings when communicating with users.

@davidtwco
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2019
@bors

This comment has been minimized.

Sign in to view
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 18, 2019
@estebank
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

📌 Commit 9daeaa8 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60061 - estebank:field-sugg, r=davidtwco
3459eaf 
Change suggestion of field when not in self context

Fix rust-lang#60057.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60061 - estebank:field-sugg, r=davidtwco
df13600 
Change suggestion of field when not in self context

Fix rust-lang#60057.
@Centril Centril mentioned this pull request Apr 19, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60061 - estebank:field-sugg, r=davidtwco
31a4e9c 
Change suggestion of field when not in self context

Fix rust-lang#60057.
@Centril Centril mentioned this pull request Apr 19, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Apr 19, 2019

Failed in #60100 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2019
@estebank
Copy link
Contributor Author

@bors r=davidtwco rebased

@bors
Copy link
Collaborator

bors commented Apr 19, 2019

📌 Commit 2f4035d has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60061 - estebank:field-sugg, r=davidtwco
aa58242 
Change suggestion of field when not in self context

Fix rust-lang#60057.
@Centril Centril mentioned this pull request Apr 19, 2019
Merged
bors added a commit that referenced this pull request Apr 19, 2019
@bors
Auto merge of #60104 - Centril:rollup-7vmae1a, r=Centril
316a391 
Rollup of 16 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #59933 (Make clear that format padding doesn't work for Debug)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60032 (Remove unwanted z-index change)
 - #60041 (Simplify the returning of a Result a bit)
 - #60045 (Suggest appropriate path when calling associated item on bare types)
 - #60052 (Correct unused parameter diagnostic)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60061 (Change suggestion of field when not in self context)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60078 (Use more realistic example for thread builder)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8)
 - #60098 (libcore: deny `elided_lifetimes_in_paths`)

Failed merges:

r? @ghost
@bors bors merged commit 2f4035d into rust-lang:master Apr 19, 2019
@davidtwco davidtwco mentioned this pull request May 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nonsensical extra diagnostics for E0425 in static methods
7 participants
@estebank @rust-highfive @davidtwco @bors @Centril @petrochenkov @eddyb