pretty-pretty extremal constants! #62457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
tesuji
reviewed
Jul 7, 2019
src/librustc/ty/print/pretty.rs
Outdated
| let max = truncate(u128::max_value(), bit_size); | ||
|
|
||
| match data { | ||
| d if d == max => p!(write("::std::{}::MAX", ui)), |
|
N.B. rust-lang/rfcs#2700 -- this will need to be updated once those constants are added. |
|
Hey! This is a ping from triage, we would like to know if you @zackmdavis could give us a few more minutes to update here so we can move forward . Thanks. |
varkor
reviewed
Jul 22, 2019
src/librustc/ty/print/pretty.rs
Outdated
| let bit_size = Integer::from_attr(&self.tcx(), UnsignedInt(ui)).size(); | ||
| let max = truncate(u128::max_value(), bit_size); | ||
|
|
||
| match data { |
There was a problem hiding this comment.
This would be clearer as an if block.
|
@zackmdavis: this looks great, thanks! Just a couple of nits to address. |
|
Thanks for the ping/review. As I recall, CI is failing due to MIR-opt tests, which I haven't found time to debug yet: expect an update by this weekend. |
|
@rustbot modify labels to +S-waiting-on-author, -S-waiting-on-review |
rustbot
added
S-waiting-on-author
|
@zackmdavis: you just need to replace the two occurrences of |
|
Ping from triage @zackmdavis any update on this? Some checks weren't successful. Thanks |
|
@gagan0723 I regret that my "expect an update by this weekend" prediction wasn't accurate for personal reasons. Please stand by. |
|
My apologies for not reading your comment above.😔 |
zackmdavis
force-pushed
the
minimax_search_and_the_structure_of_cognition
branch
from
fd04c95 to
ed4d5b5
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
While many programmers may intuitively appreciate the significance of "magic numbers" like −2147483648, Rust is about empowering everyone to build reliable and efficient software! It's a bit more legible to print the constant names (even noisy fully-qualified-paths thereof). The bit-manipulation methods mirror those in `librustc_mir::hair::pattern::_match::all_constructors`; thanks to the immortal Varkor for guidance. Resolves rust-lang#56393.
zackmdavis
force-pushed
the
minimax_search_and_the_structure_of_cognition
branch
from
ed4d5b5 to
d1cdb02
Compare
|
Thanks for your patience. @bors r=varkor |
|
📌 Commit d1cdb02 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 7, 2019
…_cognition, r=varkor pretty-pretty extremal constants! (A resurrection of the defunct #57073.) While many programmers may intuitively appreciate the significance of "magic numbers" like −2147483648, Rust is about empowering everyone to build reliable and efficient software! It's a bit more legible to print the constant names (even noisy fully-qualified-paths thereof). The bit-manipulation methods mirror those in `librustc_mir::hair::pattern::_match::all_constructors`; thanks to the immortal Varkor for guidance. Resolves #56393. r? @varkor
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(A resurrection of the defunct #57073.)
While many programmers may intuitively appreciate the significance of "magic numbers" like −2147483648, Rust is about empowering everyone to build reliable and efficient software! It's a bit more legible to print the constant names (even noisy fully-qualified-paths thereof).
The bit-manipulation methods mirror those in
librustc_mir::hair::pattern::_match::all_constructors; thanks to the immortal Varkor for guidance.Resolves #56393.
r? @varkor