Merged
Conversation
Contributor
|
Some changes occurred in diagnostic error codes |
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
matthewjasper
force-pushed
the
cleanup-borrowck-errors
branch
from
5afe132 to
18e45eb
Compare
Centril
reviewed
Jul 12, 2019
Collaborator
|
☔ The latest upstream changes (presumably #62468) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
r=me after rebase |
petrochenkov
added
S-waiting-on-author
Its methods are now inherent methods of `MirBorrowckCtxt`
The borrow checker code is already using `crate` extensively, so prefer being consistent with it.
matthewjasper
force-pushed
the
cleanup-borrowck-errors
branch
from
03f1df7 to
9709b73
Compare
Contributor
Author
|
@bors r=petrochenkov |
Collaborator
|
📌 Commit 9709b73 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Jul 15, 2019
…chenkov Cleanup borrowck errors This removes some of the unnecessary code that allowed sharing error reporting between two borrow checkers. closes #59193
Collaborator
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some of the unnecessary code that allowed sharing error reporting between two borrow checkers.
closes #59193