Skip to content

Add test for issue 53096 #63379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Add test for issue 53096 #63379

merged 2 commits into from
Aug 8, 2019

Conversation

jackh726
Copy link
Member

@jackh726 jackh726 commented Aug 8, 2019

Closes #53096

r? @oli-obk

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Aug 8, 2019

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 8, 2019

📌 Commit b8b8008 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2019
@Centril
Copy link
Contributor

Centril commented Aug 8, 2019

@bors r-

Please move the test to https://github.com/rust-lang/rust/tree/master/src/test/ui/type-alias-impl-trait :)

r=Centril,oli-obk when that is done.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 8, 2019
@jackh726
Copy link
Member Author

jackh726 commented Aug 8, 2019

@Centril done! I had put it in ui/issues since it also has #![feature(const_fn)]

@Centril
Copy link
Contributor

Centril commented Aug 8, 2019

Thanks! @bors r=Centril,oli-obk

@bors
Copy link
Collaborator

bors commented Aug 8, 2019

📌 Commit 25a2cf6 has been approved by Centril,oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 8, 2019
bors added a commit that referenced this pull request Aug 8, 2019
Rollup of 8 pull requests

Successful merges:

 - #63261 (bump rand in libcore/liballoc test suites)
 - #63316 (Update rustfmt to 1.4.4)
 - #63332 (Add an overflow check in truncate implementation for Unix.)
 - #63342 (Don't use remap-path-prefix in dep-info files.)
 - #63366 (doc: Fix typo in float from bytes methods)
 - #63370 (Fix ICE #63364)
 - #63377 (Improved documentation for compile_error!())
 - #63379 (Add test for issue 53096)

Failed merges:

r? @ghost
@bors bors merged commit 25a2cf6 into rust-lang:master Aug 8, 2019
@jackh726 jackh726 deleted the issue-53096 branch August 8, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE 2018 edition with const fn and existential type
5 participants