Skip to content

Update occurences of as_slice to as_str in comments #63815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2019
Merged

Update occurences of as_slice to as_str in comments #63815

merged 1 commit into from
Aug 23, 2019

Conversation

sebastinez
Copy link
Contributor

@sebastinez sebastinez commented Aug 22, 2019 •
edited
Loading

Fix #63792

@sebastinez
Update occurences of as_slice
03507a1 
Update occurences of as_slice to as_str
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2019
@Centril
Copy link
Contributor

Centril commented Aug 22, 2019

r? @jonas-schievink

jonas-schievink
jonas-schievink approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The change looks good.

Can you edit the PR description so that it says "Fix #63792" or "Fixes #63792" instead of "Fix of #63792"? This will close the issue automatically when the PR is merged.

@jonas-schievink jonas-schievink added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2019
@sebastinez
Copy link
Contributor Author

Thank you!
PR Description edited to “Fix #63792”

@jonas-schievink
Copy link
Contributor

Great!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 22, 2019

📌 Commit 03507a1 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2019
@bors
Copy link
Collaborator

bors commented Aug 23, 2019

⌛ Testing commit 03507a1 with merge 3def0f3...

bors added a commit that referenced this pull request Aug 23, 2019
@bors
Auto merge of #63815 - sebastinez:sebastinez-doc-#63792, r=jonas-schi…
3def0f3 
…evink

Update occurences of as_slice to as_str in comments

Fix #63792
@bors
Copy link
Collaborator

bors commented Aug 23, 2019

☀️ Test successful - checks-azure
Approved by: jonas-schievink
Pushing 3def0f3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2019
@bors bors merged commit 03507a1 into rust-lang:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink approved these changes

Assignees

@jonas-schievink jonas-schievink

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

as_slice -> as_str in the docs
6 participants
@sebastinez @rust-highfive @Centril @jonas-schievink @bors @withoutboats