-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Refactor core::run in order to address many of the issues... #6433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? Is there anything I should change? Is this remotely the right thing to do? |
This looks like a big improvement. Thanks! I just opened #6436 that implies that there is going to be a lot more churn in |
No problem. I will push a new commit.
I don't really know (I didn't make that decision originally), but I can see a couple of things that might go someway to explaining it:
I am also going to push a commit to fix the test that failed on OS X. |
I rebased due to conflicts... r? |
I just did another rebase to fix the merge issues that bors complained about. r? |
I just did another preemptive rebase. r? |
mentioned in rust-lang#2625. This change makes the module more oriented around Process values instead of having to deal with process ids directly. Apart from issues mentioned in rust-lang#2625, other changes include: - Changing the naming to be more consistent - Process/process is now used instead of a mixture of Program/program and Process/process. - More docs/tests. Some io/scheduler related issues remain (mentioned in rust-lang#2625).
directory to be the parent of the current-current directory, instead of changing to the tmp directory, which was causing issues with OS X and its /tmp => /private/tmp symlink.
@brson. Also fix a few documentation bugs.
r? |
...mentioned in #2625. This change makes the module more oriented around Process values instead of having to deal with process ids directly. Apart from issues mentioned in #2625, other changes include: - Changing the naming to be more consistent - Process/process is now used instead of a mixture of Program/program and Process/process. - More docs/tests. Some io/scheduler related issues remain (mentioned in #2625). I am not sure how best to address these.
...mentioned in #2625.
This change makes the module more oriented around
Process values instead of having to deal with process ids
directly.
Apart from issues mentioned in #2625, other changes include:
is now used instead of a mixture of Program/program and
Process/process.
Some io/scheduler related issues remain (mentioned in #2625). I am not sure how best to address these.