Skip to content

Simplify Clone for Box<[T]> #67312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

Simplify Clone for Box<[T]> #67312

merged 1 commit into from
Jan 7, 2020

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Dec 15, 2019

The bespoke BoxBuilder was basically a very simple Vec. Instead,
let's clone to a real Vec, with all of its specialization for the
task, then convert back to Box<[T]>.

@rust-highfive
Copy link
Contributor

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2019
@bors
Copy link
Collaborator

bors commented Dec 23, 2019

☔ The latest upstream changes (presumably #67540) made this pull request unmergeable. Please resolve the merge conflicts.

@cuviper
Simplify Clone for Box<[T]>
81a6709 
The bespoke `BoxBuilder` was basically a very simple `Vec`. Instead,
let's clone to a real `Vec`, with all of its specialization for the
task, then convert back to `Box<[T]>`.
@cuviper
Copy link
Member Author

cuviper commented Dec 23, 2019

Rebased.

@cuviper
Copy link
Member Author

cuviper commented Jan 7, 2020

r? @SimonSapin

@SimonSapin
Copy link
Contributor

Looks good, thanks!

@bors r+

Until something like rust-lang/highfive#241 is added, please consider using https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json to find a reviewer.

@bors
Copy link
Collaborator

bors commented Jan 7, 2020

📌 Commit 81a6709 has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2020
@cuviper
Copy link
Member Author

cuviper commented Jan 7, 2020

Until something like rust-lang/highfive#241 is added, please consider using https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json to find a reviewer.

OK, thanks for the link. I knew you were on the libs team and had touched this file relatively recently, but didn't know there was a distinct reviewer list (that you aren't on). Thanks for reviewing anyway!

@bors
Copy link
Collaborator

bors commented Jan 7, 2020

⌛ Testing commit 81a6709 with merge 8597644...

bors added a commit that referenced this pull request Jan 7, 2020
@bors
Auto merge of #67312 - cuviper:clone-box-slice, r=SimonSapin
8597644 
Simplify Clone for Box<[T]>

The bespoke `BoxBuilder` was basically a very simple `Vec`. Instead,
let's clone to a real `Vec`, with all of its specialization for the
task, then convert back to `Box<[T]>`.
@bors
Copy link
Collaborator

bors commented Jan 7, 2020

☀️ Test successful - checks-azure
Approved by: SimonSapin
Pushing 8597644 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 7, 2020
@bors bors merged commit 81a6709 into rust-lang:master Jan 7, 2020
@cuviper cuviper deleted the clone-box-slice branch April 3, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @rust-highfive @bors @SimonSapin @withoutboats