[experiment] Try using a very simple heuristic for the inliner #68795

wesleywiser · 2020-02-03T12:53:49Z

r? @ghost

@ghost

r? @ghost

wesleywiser · 2020-02-03T12:54:26Z

@bors try
@rust-timer queue

rust-timer · 2020-02-03T12:54:27Z

Awaiting bors try build completion

bors · 2020-02-03T12:54:39Z

⌛ Trying commit 6261869 with merge 80ce9f1ae6fa204a416bef15e14657568c0e26cf...

rust-highfive · 2020-02-03T13:11:21Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-03T12:54:23.3310475Z ========================== Starting Command Output ===========================
2020-02-03T12:54:23.3311947Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/501b690b-6e1d-4229-963b-8a47eae39b0c.sh
2020-02-03T12:54:23.3311982Z 
2020-02-03T12:54:23.3314397Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-03T12:54:23.3319882Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68795/merge to s
2020-02-03T12:54:23.3321277Z Task         : Get sources
2020-02-03T12:54:23.3321306Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-03T12:54:23.3321375Z Version      : 1.0.0
2020-02-03T12:54:23.3321405Z Author       : Microsoft
---
2020-02-03T12:54:24.1034191Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-03T12:54:24.1108287Z ##[command]git config gc.auto 0
2020-02-03T12:54:24.1174247Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-03T12:54:24.1223837Z ##[command]git config --get-all http.proxy
2020-02-03T12:54:24.1357808Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68795/merge:refs/remotes/pull/68795/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-03T15:50:58Z

☀️ Try build successful - checks-azure
Build commit: 80ce9f1ae6fa204a416bef15e14657568c0e26cf (80ce9f1ae6fa204a416bef15e14657568c0e26cf)

rust-timer · 2020-02-03T15:51:00Z

Queued 80ce9f1ae6fa204a416bef15e14657568c0e26cf with parent 0d34a87, future comparison URL.

rust-timer · 2020-02-03T20:14:23Z

Finished benchmarking try commit 80ce9f1ae6fa204a416bef15e14657568c0e26cf, comparison URL.

Zoxc · 2020-02-04T00:23:02Z

@wesleywiser Do you know why check builds get optimized MIR?
cc @rust-lang/compiler

Aaron1011 · 2020-02-04T00:32:27Z

According to the dep graph, it's coming from const_eval_raw, probably here:

rust/src/librustc_mir/interpret/eval_context.rs

Line 327 in 0859451

Ok(self.tcx.optimized_mir(did).unwrap_read_only())

Zoxc · 2020-02-04T00:57:44Z

Well unicode_normalization has a large constant. Maybe we're copying that due to inlining?

wesleywiser · 2020-02-04T02:11:53Z

I didn't know we did that either. I guess for consts coming from other crates, the only MIR we have is from the optimized_mir query?

rust-highfive · 2020-02-04T04:33:43Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-04T03:27:04.6149117Z ========================== Starting Command Output ===========================
2020-02-04T03:27:04.6169863Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/281d4252-2b89-44f1-a612-a2e494560cce.sh
2020-02-04T03:27:04.6350827Z 
2020-02-04T03:27:04.6423256Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-04T03:27:04.6429315Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68795/merge to s
2020-02-04T03:27:04.6431044Z Task         : Get sources
2020-02-04T03:27:04.6431078Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-04T03:27:04.6431109Z Version      : 1.0.0
2020-02-04T03:27:04.6431184Z Author       : Microsoft
---
2020-02-04T03:27:05.5065277Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-04T03:27:05.5161172Z ##[command]git config gc.auto 0
2020-02-04T03:27:05.5243680Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-04T03:27:05.5311368Z ##[command]git config --get-all http.proxy
2020-02-04T03:27:05.5461151Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68795/merge:refs/remotes/pull/68795/merge
---
2020-02-04T04:22:42.3342155Z .................................................................................................... 1700/9582
2020-02-04T04:22:47.1794338Z .................................................................................................... 1800/9582
2020-02-04T04:22:58.9095636Z ............................i....................................................................... 1900/9582
2020-02-04T04:23:05.9169507Z .................................................................................................... 2000/9582
2020-02-04T04:23:19.7335521Z ..................iiiii............................................................................. 2100/9582
2020-02-04T04:23:29.0760728Z .................................................................................................... 2300/9582
2020-02-04T04:23:31.3963656Z .................................................................................................... 2400/9582
2020-02-04T04:23:36.0147019Z .................................................................................................... 2500/9582
2020-02-04T04:23:56.5944944Z .................................................................................................... 2600/9582
---
2020-02-04T04:26:28.0009767Z .............................................................i...............i...................... 4900/9582
2020-02-04T04:26:35.2767374Z .................................................................................................... 5000/9582
2020-02-04T04:26:43.0054011Z .................................................................................................... 5100/9582
2020-02-04T04:26:47.5400929Z ....i............................................................................................... 5200/9582
2020-02-04T04:26:58.1592069Z ..............................................................................ii.ii........i...i.... 5300/9582
2020-02-04T04:27:06.2601816Z ................i................................................................................... 5500/9582
2020-02-04T04:27:15.3421221Z .................................................................................................... 5600/9582
2020-02-04T04:27:21.9037634Z .................................................................i.................................. 5700/9582
2020-02-04T04:27:28.8224831Z .................................................................................................... 5800/9582
2020-02-04T04:27:28.8224831Z .................................................................................................... 5800/9582
2020-02-04T04:27:36.0162423Z .................................................................................................... 5900/9582
2020-02-04T04:27:44.9282744Z ........................................................ii...i..ii...........i...................... 6000/9582
2020-02-04T04:28:05.7936058Z .................................................................................................... 6200/9582
2020-02-04T04:28:13.1517587Z .................................................................................................... 6300/9582
2020-02-04T04:28:13.1517587Z .................................................................................................... 6300/9582
2020-02-04T04:28:20.8579858Z ....................................................................................i..ii........... 6400/9582
2020-02-04T04:28:44.9340041Z .................................................................................................... 6600/9582
2020-02-04T04:28:54.2818035Z .......................................................................i............................ 6700/9582
2020-02-04T04:28:56.3954768Z .................................................................................................... 6800/9582
2020-02-04T04:28:58.5481709Z .........................................................................i.......................... 6900/9582
---
2020-02-04T04:30:35.5802993Z .................................................................................................... 7600/9582
2020-02-04T04:30:40.1308322Z .................................................................................................... 7700/9582
2020-02-04T04:30:46.8380544Z .................................................................................................... 7800/9582
2020-02-04T04:30:54.9932722Z .................................................................................................... 7900/9582
2020-02-04T04:31:02.3087500Z ..................................iiiiiii.i......................................................... 8000/9582
2020-02-04T04:31:16.6356607Z .................................................................................................... 8200/9582
2020-02-04T04:31:24.7436223Z .................................................................................................... 8300/9582
2020-02-04T04:31:37.9037689Z .................................................................................................... 8400/9582
2020-02-04T04:31:45.2351541Z .................................................................................................... 8500/9582
---
2020-02-04T04:33:37.3392429Z ---- [ui] ui/async-await/async-closure.rs stdout ----
2020-02-04T04:33:37.3392729Z 
2020-02-04T04:33:37.3393265Z error: test compilation failed although it shouldn't!
2020-02-04T04:33:37.3393726Z status: exit code: 101
2020-02-04T04:33:37.3394884Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/async-await/async-closure.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/async-closure/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/async-closure/auxiliary"
2020-02-04T04:33:37.3395911Z ------------------------------------------
2020-02-04T04:33:37.3396175Z 
2020-02-04T04:33:37.3396641Z ------------------------------------------
2020-02-04T04:33:37.3396931Z stderr:
2020-02-04T04:33:37.3396931Z stderr:
2020-02-04T04:33:37.3397771Z ------------------------------------------
2020-02-04T04:33:37.3398955Z error: internal compiler error: src/librustc/traits/codegen/mod.rs:57: Encountered error `OutputTypeParameterMismatch(Binder(<[closure@/checkout/src/test/ui/async-await/async-closure.rs:50:5: 53:7] as std::ops::Fn<(u8,)>>), Binder(<[closure@/checkout/src/test/ui/async-await/async-closure.rs:50:5: 53:7] as std::ops::Fn<(u8,)>>), Sorts(ExpectedFound { expected: impl std::future::Future, found: std::future::GenFuture<[static generator@/checkout/src/test/ui/async-await/async-closure.rs:50:31: 53:6 x:u8 {WakeOnceThenComplete, ()}]> }))` selecting `Binder(<[closure@/checkout/src/test/ui/async-await/async-closure.rs:50:5: 53:7] as std::ops::Fn<(u8,)>>)` during codegen
2020-02-04T04:33:37.3401485Z thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:883:9
2020-02-04T04:33:37.3401786Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-04T04:33:37.3401994Z 
2020-02-04T04:33:37.3402242Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-04T04:33:37.3402242Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-04T04:33:37.3402435Z 
2020-02-04T04:33:37.3403119Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-02-04T04:33:37.3403398Z 
2020-02-04T04:33:37.3403929Z note: rustc 1.42.0-nightly (981894c8b 2020-02-04) running on x86_64-unknown-linux-gnu
2020-02-04T04:33:37.3404205Z 
2020-02-04T04:33:37.3404813Z note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
2020-02-04T04:33:37.3405328Z error: aborting due to previous error
2020-02-04T04:33:37.3405530Z 
2020-02-04T04:33:37.3405720Z 
2020-02-04T04:33:37.3406172Z ------------------------------------------
---
2020-02-04T04:33:37.3427278Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-04T04:33:37.3427598Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-04T04:33:37.3443507Z 
2020-02-04T04:33:37.3443881Z 
2020-02-04T04:33:37.3456224Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-04T04:33:37.3458649Z 
2020-02-04T04:33:37.3458881Z 
2020-02-04T04:33:37.3461594Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-04T04:33:37.3461687Z Build completed unsuccessfully in 1:00:58
2020-02-04T04:33:37.3461687Z Build completed unsuccessfully in 1:00:58
2020-02-04T04:33:37.3518567Z == clock drift check ==
2020-02-04T04:33:37.3535288Z   local time: Tue Feb  4 04:33:37 UTC 2020
2020-02-04T04:33:37.9049227Z   network time: Tue, 04 Feb 2020 04:33:37 GMT
2020-02-04T04:33:37.9049337Z == end clock drift check ==
2020-02-04T04:33:38.2815543Z 
2020-02-04T04:33:38.2916742Z ##[error]Bash exited with code '1'.
2020-02-04T04:33:38.2929182Z ##[section]Finishing: Run build
2020-02-04T04:33:38.2948636Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68795/merge to s
2020-02-04T04:33:38.2950451Z Task         : Get sources
2020-02-04T04:33:38.2950498Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-04T04:33:38.2950545Z Version      : 1.0.0
2020-02-04T04:33:38.2950600Z Author       : Microsoft
2020-02-04T04:33:38.2950600Z Author       : Microsoft
2020-02-04T04:33:38.2950646Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-04T04:33:38.2950696Z ==============================================================================
2020-02-04T04:33:38.7232111Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-04T04:33:38.7273025Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68795/merge to s
2020-02-04T04:33:38.7387658Z Cleaning up task key
2020-02-04T04:33:38.7388420Z Start cleaning up orphan processes.
2020-02-04T04:33:38.7506317Z Terminate orphan process: pid (3828) (python)
2020-02-04T04:33:38.7726167Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

wesleywiser · 2020-02-04T09:22:56Z

@bors try
@rust-timer queue

rust-timer · 2020-02-04T09:22:58Z

Awaiting bors try build completion

bors · 2020-02-04T09:23:08Z

⌛ Trying commit facb659eec2640cd71edfb9c94fb0d3706b1abca with merge 61fc21524391da43bfc56aa003624ebec2d96776...

src/librustc_mir/transform/inline.rs

rust-highfive · 2020-02-04T12:54:21Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-04T11:54:56.4756473Z ========================== Starting Command Output ===========================
2020-02-04T11:54:56.4790444Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/f01af0ac-6f67-4205-8e8c-d33827c7c275.sh
2020-02-04T11:54:56.4790617Z 
2020-02-04T11:54:56.4793361Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-04T11:54:56.4797582Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68795/merge to s
2020-02-04T11:54:56.4798795Z Task         : Get sources
2020-02-04T11:54:56.4798820Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-04T11:54:56.4798856Z Version      : 1.0.0
2020-02-04T11:54:56.4798880Z Author       : Microsoft
---
2020-02-04T11:54:57.2398444Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-04T11:54:57.2466871Z ##[command]git config gc.auto 0
2020-02-04T11:54:57.2535458Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-04T11:54:57.2598217Z ##[command]git config --get-all http.proxy
2020-02-04T11:54:57.2710386Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68795/merge:refs/remotes/pull/68795/merge
---
2020-02-04T12:42:50.0791127Z .................................................................................................... 1700/9582
2020-02-04T12:42:54.7990839Z .................................................................................................... 1800/9582
2020-02-04T12:43:06.4166856Z ............................i....................................................................... 1900/9582
2020-02-04T12:43:13.1322855Z .................................................................................................... 2000/9582
2020-02-04T12:43:26.3756862Z ..................iiiii............................................................................. 2100/9582
2020-02-04T12:43:35.5338595Z .................................................................................................... 2300/9582
2020-02-04T12:43:38.2052883Z .................................................................................................... 2400/9582
2020-02-04T12:43:43.0018367Z .................................................................................................... 2500/9582
2020-02-04T12:44:03.2740802Z .................................................................................................... 2600/9582
---
2020-02-04T12:46:45.0837139Z .............................................................i...............i...................... 4900/9582
2020-02-04T12:46:52.8192294Z .................................................................................................... 5000/9582
2020-02-04T12:47:01.4117509Z .................................................................................................... 5100/9582
2020-02-04T12:47:06.7030193Z ....i............................................................................................... 5200/9582
2020-02-04T12:47:18.3511428Z ..............................................................................ii.ii........i...i.... 5300/9582
2020-02-04T12:47:26.9775273Z ................i................................................................................... 5500/9582
2020-02-04T12:47:36.1862644Z .................................................................................................... 5600/9582
2020-02-04T12:47:42.9666454Z .................................................................i.................................. 5700/9582
2020-02-04T12:47:50.2238174Z .................................................................................................... 5800/9582
2020-02-04T12:47:50.2238174Z .................................................................................................... 5800/9582
2020-02-04T12:47:57.5450896Z .................................................................................................... 5900/9582
2020-02-04T12:48:06.6307450Z ........................................................ii...i..ii...........i...................... 6000/9582
2020-02-04T12:48:28.2393342Z .................................................................................................... 6200/9582
2020-02-04T12:48:35.9439603Z .................................................................................................... 6300/9582
2020-02-04T12:48:35.9439603Z .................................................................................................... 6300/9582
2020-02-04T12:48:41.6315379Z ....................................................................................i..ii........... 6400/9582
2020-02-04T12:49:03.7717664Z .................................................................................................... 6600/9582
2020-02-04T12:49:13.0838260Z .......................................................................i............................ 6700/9582
2020-02-04T12:49:15.2094878Z .................................................................................................... 6800/9582
2020-02-04T12:49:17.3309892Z .........................................................................i.......................... 6900/9582
---
2020-02-04T12:50:56.9608039Z .................................................................................................... 7600/9582
2020-02-04T12:51:01.9209968Z .................................................................................................... 7700/9582
2020-02-04T12:51:09.0512415Z .................................................................................................... 7800/9582
2020-02-04T12:51:17.8377765Z .................................................................................................... 7900/9582
2020-02-04T12:51:25.3756890Z ..................................iiiiiii.i......................................................... 8000/9582
2020-02-04T12:51:39.8459363Z .................................................................................................... 8200/9582
2020-02-04T12:51:48.4000315Z .................................................................................................... 8300/9582
2020-02-04T12:52:01.5221996Z .................................................................................................... 8400/9582
2020-02-04T12:52:09.1728860Z .................................................................................................... 8500/9582
---
2020-02-04T12:53:59.2848922Z ---- [ui] ui/async-await/async-closure.rs stdout ----
2020-02-04T12:53:59.2849006Z 
2020-02-04T12:53:59.2849274Z error: test compilation failed although it shouldn't!
2020-02-04T12:53:59.2849329Z status: exit code: 101
2020-02-04T12:53:59.2850382Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/async-await/async-closure.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/async-closure/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/async-await/async-closure/auxiliary"
2020-02-04T12:53:59.2850876Z ------------------------------------------
2020-02-04T12:53:59.2850912Z 
2020-02-04T12:53:59.2851132Z ------------------------------------------
2020-02-04T12:53:59.2851340Z stderr:
2020-02-04T12:53:59.2851340Z stderr:
2020-02-04T12:53:59.2851752Z ------------------------------------------
2020-02-04T12:53:59.2852774Z error: internal compiler error: src/librustc/traits/codegen/mod.rs:57: Encountered error `OutputTypeParameterMismatch(Binder(<[closure@/checkout/src/test/ui/async-await/async-closure.rs:50:5: 53:7] as std::ops::Fn<(u8,)>>), Binder(<[closure@/checkout/src/test/ui/async-await/async-closure.rs:50:5: 53:7] as std::ops::Fn<(u8,)>>), Sorts(ExpectedFound { expected: impl std::future::Future, found: std::future::GenFuture<[static generator@/checkout/src/test/ui/async-await/async-closure.rs:50:31: 53:6 x:u8 {WakeOnceThenComplete, ()}]> }))` selecting `Binder(<[closure@/checkout/src/test/ui/async-await/async-closure.rs:50:5: 53:7] as std::ops::Fn<(u8,)>>)` during codegen
2020-02-04T12:53:59.2853319Z thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:883:9
2020-02-04T12:53:59.2853399Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-04T12:53:59.2853437Z 
2020-02-04T12:53:59.2853649Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-04T12:53:59.2853649Z note: the compiler unexpectedly panicked. this is a bug.
2020-02-04T12:53:59.2853679Z 
2020-02-04T12:53:59.2854122Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-02-04T12:53:59.2854446Z note: rustc 1.42.0-nightly (2f5665e83 2020-02-04) running on x86_64-unknown-linux-gnu
2020-02-04T12:53:59.2854501Z 
2020-02-04T12:53:59.2854501Z 
2020-02-04T12:53:59.2854992Z note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
2020-02-04T12:53:59.2855083Z error: aborting due to previous error
2020-02-04T12:53:59.2855133Z 
2020-02-04T12:53:59.2855159Z 
2020-02-04T12:53:59.2855380Z ------------------------------------------
---
2020-02-04T12:53:59.2883885Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-04T12:53:59.2884245Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-04T12:53:59.2901558Z 
2020-02-04T12:53:59.2902201Z 
2020-02-04T12:53:59.2905966Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-04T12:53:59.2906657Z 
2020-02-04T12:53:59.2906796Z 
2020-02-04T12:53:59.2914407Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-04T12:53:59.2914886Z Build completed unsuccessfully in 0:54:13
2020-02-04T12:53:59.2914886Z Build completed unsuccessfully in 0:54:13
2020-02-04T12:53:59.2970635Z == clock drift check ==
2020-02-04T12:53:59.2988996Z   local time: Tue Feb  4 12:53:59 UTC 2020
2020-02-04T12:53:59.4611947Z   network time: Tue, 04 Feb 2020 12:53:59 GMT
2020-02-04T12:53:59.4614637Z == end clock drift check ==
2020-02-04T12:53:59.8199898Z 
2020-02-04T12:53:59.8335232Z ##[error]Bash exited with code '1'.
2020-02-04T12:53:59.8348820Z ##[section]Finishing: Run build
2020-02-04T12:53:59.8372205Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68795/merge to s
2020-02-04T12:53:59.8374095Z Task         : Get sources
2020-02-04T12:53:59.8374159Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-04T12:53:59.8374205Z Version      : 1.0.0
2020-02-04T12:53:59.8374263Z Author       : Microsoft
2020-02-04T12:53:59.8374263Z Author       : Microsoft
2020-02-04T12:53:59.8374309Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-04T12:53:59.8374357Z ==============================================================================
2020-02-04T12:54:00.2722404Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-04T12:54:00.2762855Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68795/merge to s
2020-02-04T12:54:00.2926029Z Cleaning up task key
2020-02-04T12:54:00.2926756Z Start cleaning up orphan processes.
2020-02-04T12:54:00.3032879Z Terminate orphan process: pid (4564) (python)
2020-02-04T12:54:00.3315841Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bjorn3 · 2020-02-04T13:01:01Z

^ Is it possible that inlining doesn't take opaque return types into account?

wesleywiser · 2020-02-04T14:19:10Z

@bors try
@rust-timer queue

rust-timer · 2020-02-04T14:19:11Z

Awaiting bors try build completion

bors · 2020-02-04T14:19:21Z

⌛ Trying commit cf0876f with merge 0d96668e5d8c52d98ea13b30a512b086f988b305...

bors · 2020-02-04T16:54:40Z

☀️ Try build successful - checks-azure
Build commit: 0d96668e5d8c52d98ea13b30a512b086f988b305 (0d96668e5d8c52d98ea13b30a512b086f988b305)

rust-timer · 2020-02-04T16:54:42Z

Queued 0d96668e5d8c52d98ea13b30a512b086f988b305 with parent bae3d0d, future comparison URL.

rust-timer · 2020-02-04T22:06:26Z

Finished benchmarking try commit 0d96668e5d8c52d98ea13b30a512b086f988b305, comparison URL.

wesleywiser · 2020-02-04T22:11:40Z

@eddyb FYI, results seem to be very similar to the last run.

[experiment] Try using a very simple heuristic for the inliner

6261869

r? @ghost

bjorn3 reviewed Feb 4, 2020

View reviewed changes

src/librustc_mir/transform/inline.rs Outdated Show resolved Hide resolved

wesleywiser force-pushed the inline_only_very_small_funcs branch from facb659 to bd1728b Compare February 4, 2020 11:15

tweak suggested by eddyb

cf0876f

wesleywiser force-pushed the inline_only_very_small_funcs branch from bd1728b to cf0876f Compare February 4, 2020 11:54

wesleywiser closed this Feb 5, 2020

wesleywiser mentioned this pull request Feb 5, 2020

MIR inliner ICEs trying to inline async closures #68841

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[experiment] Try using a very simple heuristic for the inliner #68795

[experiment] Try using a very simple heuristic for the inliner #68795

wesleywiser commented Feb 3, 2020

wesleywiser commented Feb 3, 2020

rust-timer commented Feb 3, 2020

bors commented Feb 3, 2020

rust-highfive commented Feb 3, 2020

bors commented Feb 3, 2020

rust-timer commented Feb 3, 2020

rust-timer commented Feb 3, 2020

Zoxc commented Feb 4, 2020

Aaron1011 commented Feb 4, 2020

Zoxc commented Feb 4, 2020

wesleywiser commented Feb 4, 2020 •

edited

Loading

rust-highfive commented Feb 4, 2020

wesleywiser commented Feb 4, 2020

rust-timer commented Feb 4, 2020

bors commented Feb 4, 2020

rust-highfive commented Feb 4, 2020

bjorn3 commented Feb 4, 2020 •

edited

Loading

wesleywiser commented Feb 4, 2020

rust-timer commented Feb 4, 2020

bors commented Feb 4, 2020

bors commented Feb 4, 2020

rust-timer commented Feb 4, 2020

rust-timer commented Feb 4, 2020

wesleywiser commented Feb 4, 2020

[experiment] Try using a very simple heuristic for the inliner #68795

[experiment] Try using a very simple heuristic for the inliner #68795

Conversation

wesleywiser commented Feb 3, 2020

wesleywiser commented Feb 3, 2020

rust-timer commented Feb 3, 2020

bors commented Feb 3, 2020

rust-highfive commented Feb 3, 2020

bors commented Feb 3, 2020

rust-timer commented Feb 3, 2020

rust-timer commented Feb 3, 2020

Zoxc commented Feb 4, 2020

Aaron1011 commented Feb 4, 2020

Zoxc commented Feb 4, 2020

wesleywiser commented Feb 4, 2020 • edited Loading

rust-highfive commented Feb 4, 2020

wesleywiser commented Feb 4, 2020

rust-timer commented Feb 4, 2020

bors commented Feb 4, 2020

rust-highfive commented Feb 4, 2020

bjorn3 commented Feb 4, 2020 • edited Loading

wesleywiser commented Feb 4, 2020

rust-timer commented Feb 4, 2020

bors commented Feb 4, 2020

bors commented Feb 4, 2020

rust-timer commented Feb 4, 2020

rust-timer commented Feb 4, 2020

wesleywiser commented Feb 4, 2020

wesleywiser commented Feb 4, 2020 •

edited

Loading

bjorn3 commented Feb 4, 2020 •

edited

Loading