-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Tweak output of type params and constraints in the wrong order #70519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When encountering constraints before type arguments or lifetimes, suggest the correct order.
One thing to keep in mind is that we suggest fixing the order, but we don't proactively fix it, leading to situations like the following:
|
I think this is acceptable: it's still clear, just a little repetitive. |
Using a single label for constraints and generic arguments.
@bors r+ |
📌 Commit 17a9523 has been approved by |
⌛ Testing commit 17a9523 with merge d6ae20f50d7494dac10b3a779aa1014d7a40e0cf... |
@bors retry |
Rollup of 5 pull requests Successful merges: - rust-lang#70519 (Tweak output of type params and constraints in the wrong order) - rust-lang#70704 (Make panic unwind the default for aarch64-*-windows-msvc targets) - rust-lang#70713 (Prefer sysroot from rustc in same directory as rust-gdb) - rust-lang#70739 (def_collector, visit_fn: account for no body) - rust-lang#70827 (Use smaller span for suggestion restricting lifetime) Failed merges: r? @ghost
r? @Centril @varkor