Fixes for shootout benchmarks #7193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should probably mention this PR changes the API of Arena, it now takes &self instead of &mut self. Bad, but I couldn't think of a cleaner way to fix it. |
|
@cmr has tried the binarytrees benchmark on a machine with sufficient RAM and the correct output was produced. |
|
Thanks a lot for this. I don't think the problem with threadring is fixed (#5985). |
…lint to complain.
bors
added a commit
that referenced
this pull request
Jun 24, 2013
This PR fixes a few problems with the benchmark, mentioned in #2913. Since I do not have a 4GB RAM machine (I run rust on a puny 2GB RAM VM) I can't test binarytrees with N=20. If it works we can close #2913. Fixes: 1) binarytrees prints "long lived trees of depth" instead of "long lived tree of depth" Fixes: 2) chameneosredux -- the whitespace printed by show_number should be the same as printed by show_color Already fixed: 3) spectralnorm prints an extra Fixes: 4) threadring prints an extra Fixes: 5) fasta -- strangely, output stops half-way through line 169 -- with another 8166 lines still to do. Could not test: 6) the latest binarytrees fails with input N=20 on a 4GB machine. r?
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 20, 2021
…constructor-pedantic, r=camsteffen Move `inconsistent_struct_constructor` to pedantic The whole point of named fields is that we don't have to worry about order. The names, not the position, communicate the information, so worrying about consistency for consistency's sake is pedantic to a *T*. Cf. rust-lang#7192. changelog: [`inconsistent_struct_constructor`] is moved to pedantic. wchargin-branch: inconsistent-struct-constructor-pedantic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few problems with the benchmark, mentioned in #2913. Since I do not have a 4GB RAM machine (I run rust on a puny 2GB RAM VM) I can't test binarytrees with N=20. If it works we can close #2913.
Fixes: 1) binarytrees prints "long lived trees of depth" instead of "long lived tree of depth"
Fixes: 2) chameneosredux -- the whitespace printed by show_number should be the same as printed by show_color
Already fixed: 3) spectralnorm prints an extra \n
Fixes: 4) threadring prints an extra \n
Fixes: 5) fasta -- strangely, output stops half-way through line 169 -- with another 8166 lines still to do.
Could not test: 6) the latest binarytrees fails with input N=20 on a 4GB machine.
r?