Skip to content

rustc: map node ids through a table that ensures bitset indexes in dataflow are dense #7202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2013

Conversation

pcwalton
Copy link
Contributor

I'm pretty sure this got adequately reviewed by a combination of @nikomatsakis and @graydon so I'm rubber stamping it because I really want this in (it makes it much less likely for me to swap, allowing me to get more work done).

bors added a commit that referenced this pull request Jun 17, 2013
I'm pretty sure this got adequately reviewed by a combination of @nikomatsakis and @graydon so I'm rubber stamping it because I really want this in (it makes it much less likely for me to swap, allowing me to get more work done).
@bors bors closed this Jun 17, 2013
@bors bors merged commit 6914ff9 into rust-lang:master Jun 17, 2013
@emberian
Copy link
Member

benchmark

@emberian
Copy link
Member

@graydon @pcwalton The benchmark makes it seem like this doesn't actually have much of an effect on memory usage.

@emberian
Copy link
Member

The bench is on Linux, though, and that means lazily allocated pages, might be different on other platforms?

@nikomatsakis
Copy link
Contributor

That surprises me!

flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 3, 2021
Fix allow on some statement lints

changelog: Fix `#[allow(..)]` over statements for [`needless_collect`], [`short_circuit_statement`] and [`unnecessary_operation`]

Fixes rust-lang#7171
Fixes rust-lang#7202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants