Skip to content

diagnostics: shorten paths of unique symbols #73996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 6 commits into from
Sep 4, 2020
Merged

diagnostics: shorten paths of unique symbols #73996

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75a042e
Fix some unwanted uses of Debug formatting on user-facing messages
da-x Aug 28, 2020
7b2deb5
rustc_{errors,session}: add `delay_good_path_bug`
da-x Aug 22, 2020
07e7823
pretty: trim paths of unique symbols
da-x Sep 2, 2020
c5a6131
rustc_driver: have TrimmedDefPaths::GoodPath only for rustc
da-x Sep 3, 2020
51742be
specialization_graph: avoid trimmed paths for OverlapError
da-x Sep 3, 2020
e7d7615
rustc_lint: avoid trimmed paths for ty_find_init_error
da-x Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions compiler/rustc_driver/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ impl Callbacks for TimePassesCallbacks {
// time because it will mess up the --prints output. See #64339.
self.time_passes = config.opts.prints.is_empty()
&& (config.opts.debugging_opts.time_passes || config.opts.debugging_opts.time);
config.opts.trimmed_def_paths = TrimmedDefPaths::GoodPath;
}
}

Expand Down Expand Up @@ -159,10 +160,7 @@ pub fn run_compiler(
None => return Ok(()),
};

let sopts = config::Options {
trimmed_def_paths: TrimmedDefPaths::GoodPath,
..config::build_session_options(&matches)
};
let sopts = config::build_session_options(&matches);
Copy link
Member

@bjorn3 bjorn3 Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should tools not have trimmed paths enabled?

let cfg = interface::parse_cfgspecs(matches.opt_strs("cfg"));

let mut dummy_config = |sopts, cfg, diagnostic_output| {
Expand Down