Miri: use extern fn to expose interpreter operations to program; fix leak checker on Windows #74681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
changed the title
oli-obk
reviewed
Jul 23, 2020
|
I like how this change can be done without any boostrapping problems. r=me with the nit |
|
@bors r=oli-obk |
|
📌 Commit e715b0efabf0a0eae8bae52260a886f2a169aea9 has been approved by |
bors
added
S-waiting-on-bors
|
Fixed a typo. |
|
📌 Commit 45abbe01a2162da3998889426bba7a00af0a6e24 has been approved by |
|
@bors r=oli-obk |
|
📌 Commit 67b4f3b has been approved by |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jul 24, 2020
Miri: use extern fn to expose interpreter operations to program; fix leak checker on Windows This PR realizes an idea that @oli-obk has been suggesting for a while: to use Miri-specific `extern` functions to provide some extra capabilities to the program. Initially, we have two of these methods, which libstd itself needs: * `miri_start_panic`, which replaces the intrinsic of the same name (mostly for consistency, to avoid having multiple mechanisms for Miri-specific functionality). * `miri_static_root`, which adds an allocation to a list of static "roots" that Miri considers as not having leaked (including all memory reachable through them). This is needed for rust-lang/miri#1302. We use `extern` functions instead of intrinsics for this so that user code can more easily call these Miri hoolks -- e.g. `miri_static_root` should be useful for rust-lang/miri#1318. The Miri side of this is at rust-lang/miri#1485. r? @oli-obk
|
☀️ Test successful - checks-actions, checks-azure |
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jul 25, 2020
Miri: use extern fn to expose interpreter operations to program; fix leak checker on Windows This is the Miri side of rust-lang/rust#74681. Fixes #1302 Fixes #1318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR realizes an idea that @oli-obk has been suggesting for a while: to use Miri-specific
externfunctions to provide some extra capabilities to the program. Initially, we have two of these methods, which libstd itself needs:miri_start_panic, which replaces the intrinsic of the same name (mostly for consistency, to avoid having multiple mechanisms for Miri-specific functionality).miri_static_root, which adds an allocation to a list of static "roots" that Miri considers as not having leaked (including all memory reachable through them). This is needed for Enable leak checker on Windows miri#1302.We use
externfunctions instead of intrinsics for this so that user code can more easily call these Miri hoolks -- e.g.miri_static_rootshould be useful for rust-lang/miri#1318.The Miri side of this is at rust-lang/miri#1485.
r? @oli-obk