-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove struct_span_err function from ExtCtxt #76518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove struct_span_err function from ExtCtxt #76518
Conversation
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
FYI this wasn't what I was referring to in #76406 - No opinion on this PR, though. |
Yep, the naming is funny. I don't want to update the macro though (because I'd prefer that we used error codes everywhere \o/). |
Weird, I thought the |
Just wondering, if we write error codes everywhere doesn't mean later we will have a high chance to duplicate one of the error code? |
There is a check for that. You can't use the same error code at multiple places. |
Not same error code. Different error code but a same or a very similar message. |
We no longer to 👀
This already happens from time to time. Sometimes we leave it like that, sometimes we merge them. |
I don't see the benefit this PR brings, but I don't see its harm either. What's the rationale? If I understand correctly it was a comment about using the |
Yes, not really useful... Closing it then. |
@estebank Since we are not using |
@pickfire I would like to do that sort of clean up in a more mechanical/principled way, checking what patterns we currently use and optimize for them. |
Fixes #76508
cc @jyn514 @pickfire