Skip to content

Compute underlying type of impl trait types later in compilation #77236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2020
Merged

Compute underlying type of impl trait types later in compilation #77236

merged 2 commits into from
Sep 28, 2020

Conversation

matthewjasper
Copy link
Contributor

Also change a bug! to delay_span_bug
Closes #74018

@matthewjasper
Delay bug for non-universal regions in member constraints
ef83742
@matthewjasper
Call type_of for opaque types later in compilation
3a81ade 
This ensures that various wf checks have already been done before we
typeck item bodies.
@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2020
@vandenheuvel
Copy link
Contributor

vandenheuvel commented Sep 27, 2020 •
edited
Loading

Have you considered adding this test, or is it out of scope because of #![feature(generic_associated_types)] (it passes)?

davidtwco
davidtwco approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2020

📌 Commit 3a81ade has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2020
@bors
Copy link
Collaborator

bors commented Sep 28, 2020

⌛ Testing commit 3a81ade with merge 535d27a...

@bors
Copy link
Collaborator

bors commented Sep 28, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 535d27a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2020
@bors bors merged commit 535d27a into rust-lang:master Sep 28, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 28, 2020
@matthewjasper matthewjasper deleted the defer-typeof-impl-trait branch September 28, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

ICE when playing around with existential types, impl trait
6 participants
@matthewjasper @rust-highfive @vandenheuvel @davidtwco @bors @rustbot