Skip to content

Use DroplessArena where we know the type doesn't need drop #78134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 20, 2020

This PR uses a single DroplessArena in resolve instead of three separate TypedArenas.

DroplessArena checks that the type indeed doesn't need drop, so in case the types change, this will result in visible failures.

@rust-highfive
Copy link
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2020
@lcnr
Copy link
Contributor

lcnr commented Oct 21, 2020

might influence perf

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Oct 21, 2020

⌛ Trying commit 9b453d6 with merge 5650bcda4c0ae36febd02d8202432fdf7d187c96...

@bors
Copy link
Collaborator

bors commented Oct 21, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 5650bcda4c0ae36febd02d8202432fdf7d187c96 (5650bcda4c0ae36febd02d8202432fdf7d187c96)

@rust-timer
Copy link
Collaborator

Queued 5650bcda4c0ae36febd02d8202432fdf7d187c96 with parent f965120, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (5650bcda4c0ae36febd02d8202432fdf7d187c96): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@lcnr
Copy link
Contributor

lcnr commented Oct 21, 2020

looks like a small perf improvement.gj

r? @lcnr

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 21, 2020

📌 Commit 9b453d6 has been approved by lcnr

@rust-highfive rust-highfive assigned lcnr and unassigned varkor Oct 21, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2020
@bors
Copy link
Collaborator

bors commented Oct 22, 2020

⌛ Testing commit 9b453d6 with merge 6b9fbf2...

@bors
Copy link
Collaborator

bors commented Oct 22, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: lcnr
Pushing 6b9fbf2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 22, 2020
@bors bors merged commit 6b9fbf2 into rust-lang:master Oct 22, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 22, 2020
@bugadani bugadani deleted the arena-nodrop branch October 22, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants