-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Use DroplessArena
where we know the type doesn't need drop
#78134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
might influence perf @bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 9b453d6 with merge 5650bcda4c0ae36febd02d8202432fdf7d187c96... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 5650bcda4c0ae36febd02d8202432fdf7d187c96 with parent f965120, future comparison URL. |
Finished benchmarking try commit (5650bcda4c0ae36febd02d8202432fdf7d187c96): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
📌 Commit 9b453d6 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
This PR uses a single
DroplessArena
in resolve instead of three separateTypedArena
s.DroplessArena
checks that the type indeed doesn't need drop, so in case the types change, this will result in visible failures.