-
Notifications
You must be signed in to change notification settings - Fork 13.3k
std: IntoInnerError into_parts, NoStorageSpace #78689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -156,6 +156,11 @@ pub enum ErrorKind { | |||||
/// [`Ok(0)`]: Ok | ||||||
#[stable(feature = "rust1", since = "1.0.0")] | ||||||
WriteZero, | ||||||
/// The underlying storage (typically, a filesystem) is full. | ||||||
/// | ||||||
/// This does not include out of quota errors. | ||||||
#[stable(feature = "io_error_no_storage_space", since = "1.51.0")] | ||||||
NoStorageSpace, | ||||||
/// This operation was interrupted. | ||||||
/// | ||||||
/// Interrupted operations can typically be retried. | ||||||
|
@@ -199,6 +204,7 @@ impl ErrorKind { | |||||
ErrorKind::TimedOut => "timed out", | ||||||
ErrorKind::WriteZero => "write zero", | ||||||
ErrorKind::Interrupted => "operation interrupted", | ||||||
ErrorKind::NoStorageSpace => "no storage space", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the suggestion. I'm happy to change the message to be identical to the traditional Unix one if that seems better. But most of the existing messages do not mirror the traditional Unix ones. |
||||||
ErrorKind::Other => "other os error", | ||||||
ErrorKind::UnexpectedEof => "unexpected end of file", | ||||||
} | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.47 is stable and 1.49 is the current nightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I'm a bit pessimistic about when this might go in but if it seems right in principle I will change it obviously.