Do not ICE on generic type mismatch in anonymous const #80278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

LeSeulArtichaut wants to merge 1 commit into rust-lang:master from LeSeulArtichaut:issue-80062

Contributor

LeSeulArtichaut commented Dec 22, 2020

Fixes #80062.

rust-highfive assigned varkor

Contributor

rust-highfive commented Dec 22, 2020

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive added the S-waiting-on-review label

This comment has been minimized.

Sign in to view

LeSeulArtichaut force-pushed the issue-80062 branch from 640e7d2 to 5032c20 Compare

December 22, 2020 10:32

This comment has been minimized.

Sign in to view

LeSeulArtichaut force-pushed the issue-80062 branch from 5032c20 to 9cee678 Compare

December 22, 2020 11:16

This comment has been minimized.

Sign in to view

LeSeulArtichaut force-pushed the issue-80062 branch from 9cee678 to 8cefed1 Compare

December 22, 2020 11:43

This comment has been minimized.

Sign in to view

LeSeulArtichaut force-pushed the issue-80062 branch from 8cefed1 to c82598f Compare

December 22, 2020 12:05

This comment has been minimized.

Sign in to view


          Do not ICE on generic type mismatch in anonymous const

bae3fbb

LeSeulArtichaut force-pushed the issue-80062 branch from c82598f to bae3fbb Compare

December 22, 2020 14:05

Contributor Author

LeSeulArtichaut commented Dec 22, 2020

👆 This is what I get for being lazy and trying to avoid building the compiler 😅

varkor reviewed

View reviewed changes

compiler/rustc_infer/src/infer/error_reporting/mod.rs

                           self.tcx.hir().opt_local_def_id(cause.body_id).unwrap_or_else(|| {
                               self.tcx.hir().body_owner_def_id(hir::BodyId { hir_id: cause.body_id })
                           });
+                      if let hir::def::DefKind::AnonConst = self.tcx.hir().def_kind(body_owner_def_id) {

Member

varkor Dec 23, 2020

This seems quite subtle, for instance in being sure that AnonConst is the only special case. Are there no general methods for doing this (and should there be, if this pattern is used elsewhere)?

Contributor Author

LeSeulArtichaut Dec 23, 2020 •

edited

Loading

IIUC a DefId can be given to any of the variants of DefKind. Maybe closures/generators can cause problems too?

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors and removed S-waiting-on-review labels

Member

varkor commented Dec 30, 2020

Just noticed the original ICE (#80062) is already fixed on nightly. Perhaps this was already fixed by min_const_generics? It might be sufficient simply to add a test case for the ICE.

bors added S-waiting-on-author and removed S-waiting-on-bors labels

LeSeulArtichaut closed this

LeSeulArtichaut deleted the issue-80062 branch

December 30, 2020 12:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author