-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Borrow builder only once in debug derive #81760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit a6742ae35c19722e4dc2309461b24328926e106d with merge d589fc7d554c7ecdab26eb7ae07fd6dc7e8280f7... |
☀️ Try build successful - checks-actions |
Queued d589fc7d554c7ecdab26eb7ae07fd6dc7e8280f7 with parent 822ebfd, future comparison URL. |
Finished benchmarking try commit (d589fc7d554c7ecdab26eb7ae07fd6dc7e8280f7): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Before: let mut debug_trait_builder = ::core::fmt::Formatter::debug_struct(f, "S");
let _ = ::core::fmt::DebugStruct::field(&mut debug_trait_builder, "a", &&(*__self_0_0));
...
::core::fmt::DebugStruct::finish(&mut debug_trait_builder) After: let debug_trait_builder = &mut ::core::fmt::Formatter::debug_struct(f, "S");
let _ = ::core::fmt::DebugStruct::field(debug_trait_builder, "a", &&(*__self_0_0));
...
::core::fmt::DebugStruct::finish(debug_trait_builder) For each call to a debug builder, this implementation reduces the number of temporaries by one and the number of statements by three at MIR level. r? @pnkfelix |
@bors r+ rollup=never (the results seem acceptable, but I dont want to roll them up so that they don't mask effects of other PRs) |
📌 Commit a6742ae35c19722e4dc2309461b24328926e106d has been approved by |
⌛ Testing commit a6742ae35c19722e4dc2309461b24328926e106d with merge 917f4e66d59ebcae548077514552190b3e5d0895... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
a6742ae
to
1cf9505
Compare
Updated test output. |
@bors r+ rollup=never |
📌 Commit 1cf9505 has been approved by |
☀️ Test successful - checks-actions |
No description provided.