Skip to content

Refactor: reduce length of issue-29466 test #82044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor: reduce length of issue-29466 test #82044

wants to merge 1 commit into from

Conversation

SkiFire13
Copy link
Contributor

Part of #60302

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2021
@Mark-Simulacrum
Copy link
Member

As noted #82075 (comment) I'd prefer not to do this for this sort of test at least, it seems like it mostly just adds complexity.

@SkiFire13 SkiFire13 deleted the issue-29466-tidy-filelength branch February 21, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkiFire13 @rust-highfive @Mark-Simulacrum