Add codegen test for array comparision opt #82459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LingMan
reviewed
Feb 26, 2021
Co-authored-by: LingMan <[email protected]>
JohnCSimon
added
S-waiting-on-review
|
@jonas-schievink this is ready for review |
|
I don't really know how this works. r? @nagisa |
nagisa
reviewed
Mar 16, 2021
| #![crate_type = "lib"] | ||
|
|
||
| // CHECK-LABEL: compare | ||
| // CHECK: movb $1, %al |
There was a problem hiding this comment.
Probably should CHECK-NEXT here. There are a number of plausible ways to generate code for this that would result in these two instructions somewhere, but not necessarily in just these two instructions.
nagisa
reviewed
Mar 16, 2021
nagisa
added
S-waiting-on-author
|
This is r=me once the comment above is addressed. |
|
Ping from triage: @tesuji can you post your status on this MR and address nagisa's feedback? Thank you. |
camelid
added
A-codegen
|
Alas the issue seems to have resurfaced. I rebased the test case and it failed. Closing this to get it out of my queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62531
r? @jonas-schievink